build: turn on -fno-delete-null-pointer-checks (v0.10) #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around spec violations in V8 where it checks that `this == NULL`. GCC 6 started exploiting this particular kind of UB, resulting in runtime crashes. Fixes: nodejs#6724
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
rvagg
pushed a commit
that referenced
this pull request
Jun 23, 2016
Work around spec violations in V8 where it checks that `this == NULL`. GCC 6 started exploiting this particular kind of UB, resulting in runtime crashes. Fixes: #6724 PR-URL: #6738 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
|
@nodejs/release I assume this hasn't landed yet because v0.10.46 was a 'security fixes only' release? |
|
This landed in the staging branch but has not yet gone out in a release. If/when we have another v0.10 release it should be included. Closing the PR since the commit did land. |
rvagg
pushed a commit
that referenced
this pull request
Sep 22, 2016
Work around spec violations in V8 where it checks that `this == NULL`. GCC 6 started exploiting this particular kind of UB, resulting in runtime crashes. Fixes: #6724 PR-URL: #6738 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around spec violations in V8 where it checks that
this == NULL.GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.
Fixes: #6724
CI: https://ci.nodejs.org/job/node-test-pull-request/2634/