New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: add message for dispose deprecation #7053

Merged
merged 1 commit into from Jun 7, 2016

Conversation

Projects
None yet
2 participants
@mscdex
Contributor

mscdex commented May 29, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • domain
Description of change

I noticed that domain.dispose() had no deprecation message set, so I just basically added the deprecation text from the docs.

@mscdex mscdex added the domain label May 29, 2016

@mscdex

This comment has been minimized.

Contributor

mscdex commented May 29, 2016

@mscdex mscdex added the semver-major label May 29, 2016

@mscdex

This comment has been minimized.

Contributor

mscdex commented May 29, 2016

Marking this as semver-major since it's technically an error message change.

@jasnell

This comment has been minimized.

Member

jasnell commented May 31, 2016

LGTM

@mscdex

This comment has been minimized.

Contributor

mscdex commented Jun 7, 2016

domain: add message for dispose deprecation
PR-URL: #7053
Reviewed-By: James M Snell <jasnell@gmail.com>

@mscdex mscdex force-pushed the mscdex:domain-dispose-add-deprecation-msg branch to 3b8ec68 Jun 7, 2016

@mscdex mscdex merged commit 3b8ec68 into nodejs:master Jun 7, 2016

@mscdex mscdex deleted the mscdex:domain-dispose-add-deprecation-msg branch Jun 7, 2016

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment