Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: add message for dispose deprecation #7053

Merged
merged 1 commit into from Jun 7, 2016
Merged

domain: add message for dispose deprecation #7053

merged 1 commit into from Jun 7, 2016

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented May 29, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • domain
Description of change

I noticed that domain.dispose() had no deprecation message set, so I just basically added the deprecation text from the docs.

@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label May 29, 2016
@mscdex
Copy link
Contributor Author

mscdex commented May 29, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2854/

@mscdex mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 29, 2016
@mscdex
Copy link
Contributor Author

mscdex commented May 29, 2016 •
edited

Marking this as semver-major since it's technically an error message change.

@jasnell
Copy link
Member

jasnell commented May 31, 2016

LGTM

@mscdex
Copy link
Contributor Author

mscdex commented Jun 7, 2016

One last CI before landing: https://ci.nodejs.org/job/node-test-pull-request/2943/

@mscdex
domain: add message for dispose deprecation
3b8ec68 
PR-URL: nodejs#7053
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex force-pushed the domain-dispose-add-deprecation-msg branch from 0243205 to 3b8ec68 Compare June 7, 2016 04:28
@mscdex mscdex merged commit 3b8ec68 into nodejs:master Jun 7, 2016
@mscdex mscdex deleted the domain-dispose-add-deprecation-msg branch June 7, 2016 04:29
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain Issues and PRs related to the domain subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mscdex @jasnell