src: fix ArrayBuffer size for zero fill flag #7142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `sizeof()` of the zero fill flag as the byte length of the `zeroFill` array buffer rather than `1`. This fixes running debug builds, which have boundary checks for typed array creations from native code enabled. Fixes: nodejs#7140
addaleax
added
buffer
|
CI: https://ci.nodejs.org/job/node-test-commit/3642/ /cc @nodejs/buffer |
|
LGTM |
4 tasks
|
LGTM |
|
Ai, glaringly obvious in hindsight. LGTM. |
|
LGTM |
seishun
pushed a commit
that referenced
this pull request
Jun 4, 2016
Use `sizeof()` of the zero fill flag as the byte length of the `zeroFill` array buffer rather than `1`. This fixes running debug builds, which have boundary checks for typed array creations from native code enabled. PR-URL: #7142 Fixes: #7140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
|
Landed in ac0665c. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
buffer
Description of change
Use
sizeof()of the zero fill flag as the byte length of thezeroFillarray buffer rather than1.This fixes running debug builds, which have boundary checks for typed array creations from native code enabled.
Fixes: #7140
Labelling this this as dont-land-* like #7082 itself.