buffer: remove obsolete and confusing comment #7264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment applied to a line that was removed in dd67608 and is no longer relevant.
nodejs-github-bot
added
the
buffer
|
/cc @nodejs/buffer |
|
LGTM. It's indeed a leftover from refactoring. |
|
LGTM |
|
Landed in bd23290. |
|
Yes, that comment was irrelevant after the change, I forgot to remove it in my commit. |
|
This is not landing cleanly on v6.x. Going to hold off for now |
|
@evanlucas Strange. It should land cleanly, it's just a removal of lines https://github.com/nodejs/node/blob/v6.x/lib/buffer.js#L213-L215. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
buffer
Description of change
This comment applied to a line that was removed in dd67608 and is no longer relevant.
...Or so it seems. The reason for keeping it was possibly discussed in https://github.com/nodejs/node-private/pull/30, but I don't have access to it.