New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix V8 5.1 tests #7488

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@targos
Member

targos commented Jun 29, 2016

Checklist
  • make test-v8 passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

Description of change

Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update.

Fixes: #7477

deps: fix V8 5.1 tests
Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update.

Fixes: #7477
@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Jun 29, 2016

WOW. Whitespace causing this pain is pretty wonderful.

ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/165/

@ofrobots

This comment has been minimized.

Contributor

ofrobots commented Jun 29, 2016

😢 As mentioned in another thread recently, we should really consider landing deps changes without --whitespace=fix

@mscdex mscdex added the test label Jun 29, 2016

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Jun 29, 2016

benchmark is green. I'm +1 on revisiting whitespace-fix for dependnecies... thoughts @nodejs/ctc?

@mscdex

This comment has been minimized.

Contributor

mscdex commented Jun 29, 2016

I think I agree.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 29, 2016

LGTM

targos added a commit to targos/node that referenced this pull request Jun 30, 2016

deps: fix V8 5.1 tests
Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update and are needed for the tests to pass.

Fixes: nodejs#7477
PR-URL: nodejs#7488
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos

This comment has been minimized.

Member

targos commented Jun 30, 2016

landed in dc17432

@targos targos closed this Jun 30, 2016

@targos targos deleted the targos:fix-v8-tests branch Jun 30, 2016

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Jul 5, 2016

Please add the relevant label(s) for master-only commits. Thanks.

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment