New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 5.1.281.75 #7615

Merged
merged 1 commit into from Jul 9, 2016

Conversation

Projects
None yet
7 participants
@bnoordhuis
Member

bnoordhuis commented Jul 8, 2016

Pick up the latest branch-head for V8 5.1. Introduces a semver-minor
overload of v8::Function::New() for use by v8_inspector.

Refs: #7586

R=@nodejs/v8

CI: https://ci.nodejs.org/job/node-test-pull-request/3220/
CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/184/

@cjihrig

This comment has been minimized.

Contributor

cjihrig commented Jul 8, 2016

LGTM

1 similar comment
@targos

This comment has been minimized.

Member

targos commented Jul 8, 2016

LGTM

@indutny

This comment has been minimized.

Member

indutny commented Jul 8, 2016

Rubber-stamp LGTM

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Jul 8, 2016

LGTM if CI is green

deps: update V8 to 5.1.281.75
Pick up the latest branch-head for V8 5.1.  Introduces a semver-minor
overload of v8::Function::New() for use by v8_inspector.

Refs: #7586
PR-URL: #7615
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@bnoordhuis bnoordhuis force-pushed the bnoordhuis:v8-5.1.281.75 branch to 245ac30 Jul 9, 2016

@bnoordhuis bnoordhuis closed this Jul 9, 2016

@bnoordhuis bnoordhuis deleted the bnoordhuis:v8-5.1.281.75 branch Jul 9, 2016

@bnoordhuis bnoordhuis merged commit 245ac30 into nodejs:master Jul 9, 2016

@bnoordhuis

This comment has been minimized.

Member

bnoordhuis commented Jul 9, 2016

@Fishrock123 Out of curiosity, why did @nodejs-github-bot add the 'lib / src' label? All the changes were in deps/v8.

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Jul 9, 2016

@bnoordhuis --> nodejs/github-bot#53

"labels: prevent deps from getting "lib / src" label "

@i5ting

This comment has been minimized.

i5ting commented Jul 19, 2016

nice job

ofrobots added a commit to ofrobots/node that referenced this pull request Aug 25, 2016

deps: update V8 to 5.1.281.75
Pick up the latest branch-head for V8 5.1. This branch brings in
improved language support and performance improvements. For full
details: http://v8project.blogspot.com/2016/04/v8-release-51.html

* Picks up the latest branch head for 5.1 [1]
* Edit v8 gitignore to allow trace_event copy
* Update V8 DEP trace_event as per deps/v8/DEPS [2]

[1] https://chromium.googlesource.com/v8/v8.git/+/5.1.281.75
[2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/c8c8665

Introduces a semver-minor overload of v8::Function::New() for use
by v8_inspector.

PR-URL: nodejs#8054
Refs: nodejs#7016
Refs: nodejs#7586
Refs: nodejs#7615
Reviewed-By: addaleax - Anna Henningsen <anna@addaleax.net>
Reviewed-By: thealphanerd - Myles Borins <myles.borins@gmail.com>
Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment