doc: add added: information for events
#7822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
| @@ -167,6 +167,9 @@ myEmitter.emit('error', new Error('whoops!')); | |||
| ``` | |||
|
|
|||
| ## Class: EventEmitter | |||
| <!-- YAML | |||
| added: v0.1.90 | |||
There was a problem hiding this comment.
You are correct, I'll fix it.
There was a problem hiding this comment.
Sorry, it's actually v0.1.26.
|
|
|
|
||
| * `eventName` {String|Symbol} The event name | ||
| * `listener` {Function} The event handler function | ||
|
|
||
| The `'removeListener'` event is emitted *after* the `listener` is removed. | ||
|
|
||
| ### EventEmitter.listenerCount(emitter, eventName) | ||
| <!-- YAML | ||
| added: v0.9.12 | ||
| --> |
There was a problem hiding this comment.
Sorry, I forgot to add that there should also be: deprecated: v4.0.0
|
LGTM |
|
I missed quite a few things, thanks for reviewing @mscdex. |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 5, 2016
PR-URL: #7822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 769f63c |
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
PR-URL: #7822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
36 tasks
|
This is not backporting to v4.x cleanly. Please feel free to manually backport |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 1, 2016
PR-URL: nodejs#7822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578