-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add added:
information for events
#7822
Conversation
@@ -167,6 +167,9 @@ myEmitter.emit('error', new Error('whoops!')); | |||
``` | |||
|
|||
## Class: EventEmitter | |||
<!-- YAML | |||
added: v0.1.90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be v0.1.33.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, I'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it's actually v0.1.26.
|
|
||
* `eventName` {String|Symbol} The event name | ||
* `listener` {Function} The event handler function | ||
|
||
The `'removeListener'` event is emitted *after* the `listener` is removed. | ||
|
||
### EventEmitter.listenerCount(emitter, eventName) | ||
<!-- YAML | ||
added: v0.9.12 | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to add that there should also be: deprecated: v4.0.0
LGTM |
I missed quite a few things, thanks for reviewing @mscdex. |
LGTM |
PR-URL: #7822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Landed in 769f63c |
PR-URL: #7822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
This is not backporting to v4.x cleanly. Please feel free to manually backport |
PR-URL: nodejs#7822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578