New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: removing unused StringValue macro parameters #7905

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@danbev
Member

danbev commented Jul 28, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

Currently, there are a few places where macro functions passed to the
PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and
PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter.

This commit removes the StringValue parameter where it is not used.

@bnoordhuis

This comment has been minimized.

Member

bnoordhuis commented Jul 28, 2016

The reason I left that in is so you don't have to go searching for the type of the second parameter.

@danbev

This comment has been minimized.

Member

danbev commented Jul 28, 2016

The reason I left that in is so you don't have to go searching for the type of the second parameter.

Sorry if I'm misunderstanding you here. When I was reading the code I was looking for usage of StringValue, but could not find any (in the places covered by this PR I mean), despite the V macros having defined it as a parameter.

I'm happy to have this PR closed as I just wanted to raise this in case it was something that was overlooked.

@bnoordhuis

This comment has been minimized.

Member

bnoordhuis commented Jul 28, 2016

What I mean is that calling it 'ignored' means you have to go hunting for the PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES define if you want to know what the type of the second argument is, that's why I gave it a name that conveys that information (and also for consistency with other places where that macro is used.)

@danbev

This comment has been minimized.

Member

danbev commented Jul 28, 2016

What I mean is that calling it 'ignored' means you have to go hunting for the PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES

Ah I see, thanks for clarifying. I'll change it back to StringValue.

@addaleax

This comment has been minimized.

Member

addaleax commented Aug 22, 2016

@Trott Trott force-pushed the nodejs:master branch to c5ce7f4 Sep 21, 2016

src: remove unused StringValue macro parameters
Currently, there are a few places where macro functions passed to the
PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and
PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter.

This commit removes the StringValue parameter where it is not used.

@danbev danbev force-pushed the danbev:removing-unused-StringValue-macro-parameter branch to c7b3871 Sep 22, 2016

@danbev

This comment has been minimized.

Member

danbev commented Sep 22, 2016

Sorry, I forgot about this PR. I've rebased it now.

CI: https://ci.nodejs.org/job/node-test-pull-request/4204/

@addaleax

LGTM, CI looks good

danbev added a commit to danbev/node that referenced this pull request Sep 23, 2016

src: remove unused StringValue macro parameters
Currently, there are a few places where macro functions passed to the
PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and
PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter.

This commit removes the StringValue parameter where it is not used.

PR-URL: nodejs#7905
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danbev

This comment has been minimized.

Member

danbev commented Sep 23, 2016

Thanks for the reviews!

Landed in: 84eaa4a

@danbev danbev closed this Sep 23, 2016

@danbev danbev deleted the danbev:removing-unused-StringValue-macro-parameter branch Sep 26, 2016

jasnell added a commit that referenced this pull request Sep 29, 2016

src: remove unused StringValue macro parameters
Currently, there are a few places where macro functions passed to the
PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and
PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter.

This commit removes the StringValue parameter where it is not used.

PR-URL: #7905
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Oct 10, 2016

resolves to an empty commit on v6

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment