-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update windows prerequisites #8049
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio 2013 is no longer supported. Update the Windows build prerequisites. Refs: nodejs#7484
LGTM |
Why the update 3? Any VS2015 should do. |
Mostly because I don't want to be chasing bugs in older updates, same when I tell people to upgrade to gcc 4.8.5 when they hit a bug with 4.8.0. |
LGTM |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Aug 11, 2016
We can remove some Visual Studio 2013-specific workarounds now that support for that compiler has officially been dropped. Refs: nodejs#7484 Refs: nodejs#8049
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Aug 11, 2016
Support for Visual Studio 2013 has officially been dropped, remove the build option for that compiler. Refs: nodejs#7484 Refs: nodejs#8049
Landed in b948744 |
Merged
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Sep 23, 2016
We can remove some Visual Studio 2013-specific workarounds now that support for that compiler has officially been dropped. PR-URL: nodejs#8067 Refs: nodejs#7484 Refs: nodejs#8049 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joao Reis <reis@janeasystems.com>
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Sep 23, 2016
Support for Visual Studio 2013 has officially been dropped, remove the build option for that compiler. PR-URL: nodejs#8067 Refs: nodejs#7484 Refs: nodejs#8049 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joao Reis <reis@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2013 is no longer supported. Update the Windows build
prerequisites.
Refs: #7484