Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: alias toLocaleString to toString #8148

Closed
wants to merge 1 commit into from
Closed

buffer: alias toLocaleString to toString #8148

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Buffer

Description of change

Make Buffer.prototype.toLocaleString an alias of Buffer.prototype.toString so that the output is actually useful.

Fixes: #8147

/cc @nodejs/buffer

@jasnell
buffer: alias toLocaleString to toString
e9951ce 
Make Buffer.prototype.toLocaleString an alias of Buffer.prototype.toString
so that the output is actually useful.

Fixes: nodejs#8147
@jasnell jasnell added buffer Issues and PRs related to the buffer subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 17, 2016
@jasnell
Copy link
Member Author

jasnell commented Aug 17, 2016

Defensively marking this as a semver-major. It might be ok as a semver-minor since toLocaleString is an inherited API that was never originally considered part of the Buffer object.

@addaleax
Copy link
Member

LGTM I guess, CI: https://ci.nodejs.org/job/node-test-commit/4631/

@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2016

Build bot failure... just to be safe: https://ci.nodejs.org/job/node-test-pull-request/3736/

@jasnell
Copy link
Member Author

jasnell commented Aug 22, 2016

@nodejs/ctc @trevnorris ... ping ... just need a quick review on this one. Would this need to be semver-major?

@trevnorris
Copy link
Contributor

LGTM

jasnell added a commit that referenced this pull request Aug 23, 2016
@jasnell
buffer: alias toLocaleString to toString
9cee8b1 
Make Buffer.prototype.toLocaleString an alias of Buffer.prototype.toString
so that the output is actually useful.

Fixes: #8147
PR-URL: #8148
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Aug 23, 2016

Landed in 9cee8b1

@jasnell jasnell closed this Aug 23, 2016
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasnell @addaleax @trevnorris