Update v8_inspector #8150

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
7 participants
@ofrobots
Contributor

ofrobots commented Aug 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps, inspector

Description of change

Update to the latest version of upstream v8_inspector.

/cc @eugeneo, @bnoordhuis

@mscdex mscdex added the inspector label Aug 17, 2016

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Aug 18, 2016

Member

Doesn't seem to build on smartos because the toolchain is so ancient there:

InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.3g", number);

The Windows CI failure appears to have been a network outage.

Member

bnoordhuis commented Aug 18, 2016

Doesn't seem to build on smartos because the toolchain is so ancient there:

InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.3g", number);

The Windows CI failure appears to have been a network outage.

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Aug 19, 2016

Contributor

I added snprintf macro, same as the one in Node sources. Is it possible to
test this on SmartOS - https://github.com/eugeneo/node/tree/snprintf?

The macro is in PlatformSTL.h

On Thu, Aug 18, 2016 at 12:27 AM Ben Noordhuis notifications@github.com
wrote:

Doesn't seem to build on smartos because the toolchain is so ancient there:

InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
std::snprintf(buffer, length, "%.3g", number);

The Windows CI failure appears to have been a network outage.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrfBfaVrZkD2W3m0I7_i1bY0IHBadks5qhAlsgaJpZM4Jm-sE
.

Contributor

eugeneo commented Aug 19, 2016

I added snprintf macro, same as the one in Node sources. Is it possible to
test this on SmartOS - https://github.com/eugeneo/node/tree/snprintf?

The macro is in PlatformSTL.h

On Thu, Aug 18, 2016 at 12:27 AM Ben Noordhuis notifications@github.com
wrote:

Doesn't seem to build on smartos because the toolchain is so ancient there:

InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
std::snprintf(buffer, length, "%.3g", number);

The Windows CI failure appears to have been a network outage.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrfBfaVrZkD2W3m0I7_i1bY0IHBadks5qhAlsgaJpZM4Jm-sE
.

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Aug 19, 2016

Contributor

Thank you. Looks like the approach is correct in principle. I will put the
shim into std:: namespace.

On Fri, Aug 19, 2016 at 11:13 AM Ben Noordhuis notifications@github.com
wrote:

https://ci.nodejs.org/job/node-test-commit-smartos/3813/


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrUvnWq6XkGplmCGZaUWYzWINkSi5ks5qhfIygaJpZM4Jm-sE
.

Contributor

eugeneo commented Aug 19, 2016

Thank you. Looks like the approach is correct in principle. I will put the
shim into std:: namespace.

On Fri, Aug 19, 2016 at 11:13 AM Ben Noordhuis notifications@github.com
wrote:

https://ci.nodejs.org/job/node-test-commit-smartos/3813/


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrUvnWq6XkGplmCGZaUWYzWINkSi5ks5qhfIygaJpZM4Jm-sE
.

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Aug 19, 2016

Contributor

How can I detect SmartOS? From a compiler message, my understanding is that
it has snprintf but not the std::snprintf.

On Fri, Aug 19, 2016 at 2:03 PM Eugene Ostroukhov eostroukhov@google.com
wrote:

Thank you. Looks like the approach is correct in principle. I will put the
shim into std:: namespace.

On Fri, Aug 19, 2016 at 11:13 AM Ben Noordhuis notifications@github.com
wrote:

https://ci.nodejs.org/job/node-test-commit-smartos/3813/


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrUvnWq6XkGplmCGZaUWYzWINkSi5ks5qhfIygaJpZM4Jm-sE
.

Contributor

eugeneo commented Aug 19, 2016

How can I detect SmartOS? From a compiler message, my understanding is that
it has snprintf but not the std::snprintf.

On Fri, Aug 19, 2016 at 2:03 PM Eugene Ostroukhov eostroukhov@google.com
wrote:

Thank you. Looks like the approach is correct in principle. I will put the
shim into std:: namespace.

On Fri, Aug 19, 2016 at 11:13 AM Ben Noordhuis notifications@github.com
wrote:

https://ci.nodejs.org/job/node-test-commit-smartos/3813/


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrUvnWq6XkGplmCGZaUWYzWINkSi5ks5qhfIygaJpZM4Jm-sE
.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Aug 20, 2016

Member

In libuv we wrap smartos-specific code in #ifdef _sun guards but that also covers other illumos derivatives and solaris proper. Perhaps @misterdjules has suggestions?

Member

bnoordhuis commented Aug 20, 2016

In libuv we wrap smartos-specific code in #ifdef _sun guards but that also covers other illumos derivatives and solaris proper. Perhaps @misterdjules has suggestions?

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Aug 22, 2016

Contributor

@bnoordhuis - Can you please test this branch? It imports existing snprintf into the std namespace. Looks like SmartOS has the snprintf in the global namespace.

Contributor

eugeneo commented Aug 22, 2016

@bnoordhuis - Can you please test this branch? It imports existing snprintf into the std namespace. Looks like SmartOS has the snprintf in the global namespace.

@misterdjules

This comment has been minimized.

Show comment
Hide comment
@misterdjules

misterdjules Aug 22, 2016

_sun is the right macro to test against when detecting the SmartOS platform.

_sun is the right macro to test against when detecting the SmartOS platform.

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Aug 23, 2016

Contributor

I submitted the SmartOS fix to the Chrome yesterday and it is now available in the latest V8 inspector export.

Contributor

eugeneo commented Aug 23, 2016

I submitted the SmartOS fix to the Chrome yesterday and it is now available in the latest V8 inspector export.

Eugene Ostroukhov added some commits Aug 23, 2016

deps: v8_inspector update
Pick up latest from [1] corresponding to the Blink commit 60cd6e859b.

[1]: pavelfeldman/v8_inspector@55f21a5
@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Aug 23, 2016

Contributor

Updated the PR to pick up upstream fixes from @eugeneo. New CI: https://ci.nodejs.org/job/node-test-pull-request/3801/

Contributor

ofrobots commented Aug 23, 2016

Updated the PR to pick up upstream fixes from @eugeneo. New CI: https://ci.nodejs.org/job/node-test-pull-request/3801/

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Aug 23, 2016

Contributor

Launched a new CI: https://ci.nodejs.org/job/node-test-pull-request/3813/ because of hiccups on the last one. AIX seems to be having issues in the CI in general today.

Contributor

ofrobots commented Aug 23, 2016

Launched a new CI: https://ci.nodejs.org/job/node-test-pull-request/3813/ because of hiccups on the last one. AIX seems to be having issues in the CI in general today.

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Aug 26, 2016

Contributor

One more CI: https://ci.nodejs.org/job/node-test-pull-request/3846/. This PR does need an LGTM before I can land this (/cc @bnoordhuis)

Contributor

ofrobots commented Aug 26, 2016

One more CI: https://ci.nodejs.org/job/node-test-pull-request/3846/. This PR does need an LGTM before I can land this (/cc @bnoordhuis)

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Aug 30, 2016

Member

LGTM

Member

bnoordhuis commented Aug 30, 2016

LGTM

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Aug 30, 2016

Contributor

Landed as 1e0bfac...1b8accf.

Contributor

ofrobots commented Aug 30, 2016

Landed as 1e0bfac...1b8accf.

@ofrobots ofrobots closed this Aug 30, 2016

ofrobots added a commit that referenced this pull request Aug 30, 2016

deps: v8_inspector update
Pick up latest from [1] corresponding to the Blink commit 60cd6e859b.

[1]: pavelfeldman/v8_inspector@55f21a5

PR-URL: #8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

ofrobots added a commit that referenced this pull request Aug 30, 2016

inspector: use new inspector headers
PR-URL: #8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

deps: v8_inspector update
Pick up latest from [1] corresponding to the Blink commit 60cd6e859b.

[1]: pavelfeldman/v8_inspector@55f21a5

PR-URL: nodejs#8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

inspector: use new inspector headers
PR-URL: nodejs#8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

deps: v8_inspector update
Pick up latest from [1] corresponding to the Blink commit 60cd6e859b.

[1]: pavelfeldman/v8_inspector@55f21a5

PR-URL: #8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

inspector: use new inspector headers
PR-URL: #8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
@Bilge

This comment has been minimized.

Show comment
Hide comment
@Bilge

Bilge Dec 27, 2016

I have this problem.

/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::intToStr(int, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:23:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%d", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:28:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%f", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr3(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.3g", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr6(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:38:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.6g", number);
     ^

I am using a uClibc 0.9.33.2 toolchain (latest) available from this crosstool-NG project.

It is probably incorrect to change compilation strategy based on platform flags instead of detecting feature availability.

Bilge commented Dec 27, 2016

I have this problem.

/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::intToStr(int, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:23:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%d", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:28:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%f", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr3(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.3g", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr6(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:38:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.6g", number);
     ^

I am using a uClibc 0.9.33.2 toolchain (latest) available from this crosstool-NG project.

It is probably incorrect to change compilation strategy based on platform flags instead of detecting feature availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment