New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add `added:` information for dgram #8196

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@lpinca
Member

lpinca commented Aug 20, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

Returns an object containing the address information for a socket.
For UDP sockets, this object will contain `address`, `family` and `port`
properties.
### socket.bind([port][, address][, callback])
<!-- YAML
added: v0.1.99

This comment has been minimized.

@lpinca

lpinca Aug 20, 2016

Member

The callback argument was actually added in version 0.9.1. I'm not sure what version to use.
There are other inconsistencies like this below.

@lpinca

lpinca Aug 20, 2016

Member

The callback argument was actually added in version 0.9.1. I'm not sure what version to use.
There are other inconsistencies like this below.

This comment has been minimized.

@yorkie

yorkie Aug 20, 2016

Member

I think this should be noted as updated: v0.9.1 even thought we have not that option :-(

@yorkie

yorkie Aug 20, 2016

Member

I think this should be noted as updated: v0.9.1 even thought we have not that option :-(

This comment has been minimized.

@evanlucas

evanlucas Aug 20, 2016

Member

IIRC, we have not documenting when an argument or something like a property in an options object is added.

@evanlucas

evanlucas Aug 20, 2016

Member

IIRC, we have not documenting when an argument or something like a property in an options object is added.

This comment has been minimized.

@Qard

Qard Aug 23, 2016

Member

Yeah, we don't currently document changes well. It'd be nice if we had per-function changelogs, like PHP.

@Qard

Qard Aug 23, 2016

Member

Yeah, we don't currently document changes well. It'd be nice if we had per-function changelogs, like PHP.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 23, 2016

Member

bump

Member

Trott commented Aug 23, 2016

bump

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 23, 2016

Member

LGTM although I haven't checked the validity of the data. Not sure if that's supposed to be part of the process on these or not.

Member

Trott commented Aug 23, 2016

LGTM although I haven't checked the validity of the data. Not sure if that's supposed to be part of the process on these or not.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2016

Member

@Trott ... yes, double checking the validity of the versions is a good thing but it's also something that can be fixed separately if some of the details are off.

Member

jasnell commented Aug 24, 2016

@Trott ... yes, double checking the validity of the versions is a good thing but it's also something that can be fixed separately if some of the details are off.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2016

Member

LGTM

Member

jasnell commented Aug 24, 2016

LGTM

jasnell added a commit that referenced this pull request Aug 25, 2016

doc: add `added:` information for dgram
PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 25, 2016

Member

Landed in 379d916

Member

jasnell commented Aug 25, 2016

Landed in 379d916

@jasnell jasnell closed this Aug 25, 2016

@lpinca lpinca deleted the lpinca:add/added-dgram branch Aug 25, 2016

@lpinca lpinca referenced this pull request Aug 26, 2016

Closed

doc: add `added:` information for crypto #8281

2 of 2 tasks complete

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: add `added:` information for dgram
PR-URL: nodejs#8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: add `added:` information for dgram
PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

this is not landing cleanly on v4.x please feel free to backport

Member

MylesBorins commented Sep 30, 2016

this is not landing cleanly on v4.x please feel free to backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016

doc: add `added:` information for dgram
PR-URL: nodejs#8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 4, 2016

doc: add `added:` information for dgram
Ref: #8883

PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: add `added:` information for dgram
Ref: #8883

PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: add `added:` information for dgram
Ref: #8883

PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: add `added:` information for dgram
Ref: #8883

PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment