New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add `added:` information for crypto #8281

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@lpinca
Member

lpinca commented Aug 26, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@@ -972,6 +1130,9 @@ The `key` is the raw key used by the `algorithm` and `iv` is an
[buffers][`Buffer`].
### crypto.createDiffieHellman(prime[, prime_encoding][, generator][, generator_encoding])

This comment has been minimized.

@lpinca

lpinca Aug 26, 2016

Member

This signature was added in v0.11.12. Maybe it makes sense to use this version instead of v0.5.0. See below for the original signature.

Edit: To be picky the second argument of the original version was the encoding so I'm not sure.

@lpinca

lpinca Aug 26, 2016

Member

This signature was added in v0.11.12. Maybe it makes sense to use this version instead of v0.5.0. See below for the original signature.

Edit: To be picky the second argument of the original version was the encoding so I'm not sure.

This comment has been minimized.

@benjamingr

benjamingr Aug 26, 2016

Member

I think 0.11.12 does make more sense. If someone wants to look at the 0.10 docs to find the original that's fine.

@benjamingr

benjamingr Aug 26, 2016

Member

I think 0.11.12 does make more sense. If someone wants to look at the 0.10 docs to find the original that's fine.

This comment has been minimized.

@lpinca

lpinca Aug 26, 2016

Member

I used v0.5.0 here as per this comment but in the same pr I used two different versions (v0.11.13 and v0.1.99) for dgram.createSocket.
I'm going to do the same here.

@lpinca

lpinca Aug 26, 2016

Member

I used v0.5.0 here as per this comment but in the same pr I used two different versions (v0.11.13 and v0.1.99) for dgram.createSocket.
I'm going to do the same here.

@benjamingr

This comment has been minimized.

Show comment
Hide comment
@benjamingr

benjamingr Aug 26, 2016

Member

LGTM + left comment

Member

benjamingr commented Aug 26, 2016

LGTM + left comment

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 10, 2016

Member

Rubber-stamp LGTM

Member

addaleax commented Sep 10, 2016

Rubber-stamp LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 12, 2016

Member

LGTM

Member

jasnell commented Sep 12, 2016

LGTM

jasnell added a commit that referenced this pull request Sep 12, 2016

doc: add `added:` information for crypto
PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 12, 2016

Member

Landed in cfe8278

Member

jasnell commented Sep 12, 2016

Landed in cfe8278

@jasnell jasnell closed this Sep 12, 2016

@lpinca lpinca deleted the lpinca:add/added-crypto branch Sep 12, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

doc: add `added:` information for crypto
PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

Member

MylesBorins commented Sep 30, 2016

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016

doc: add `added:` information for crypto
PR-URL: nodejs#8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 4, 2016

doc: add `added:` information for crypto
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: add `added:` information for crypto
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: add `added:` information for crypto
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: add `added:` information for crypto
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

tniessen added a commit to tniessen/node that referenced this pull request Feb 8, 2018

@tniessen tniessen referenced this pull request Feb 8, 2018

Closed

crypto: fix meta and description #18651

2 of 2 tasks complete

tniessen added a commit that referenced this pull request Feb 9, 2018

doc: add missing meta for createCipheriv
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 21, 2018

doc: add missing meta for createCipheriv
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 21, 2018

doc: add missing meta for createCipheriv
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 21, 2018

doc: add missing meta for createCipheriv
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 21, 2018

doc: add missing meta for createCipheriv
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

gibfahn added a commit that referenced this pull request Apr 13, 2018

doc: add missing meta for createCipheriv
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

doc: add missing meta for createCipheriv
PR-URL: nodejs#18651
Refs: nodejs#8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment