test: refactor test-net-pipe-connect-errors #8473

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@Trott
Member

Trott commented Sep 9, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

Description of change
  • var -> const
  • try/catch -> assert.throws()
  • assert.ok(fail) -> common.fail()
  • assert.equal() -> assert.strictEqual()
  • replace exit handler with common.mustCall()
test: refactor test-net-pipe-connect-errors
* var -> const
* try/catch -> assert.throws()
* assert.ok(fail) -> common.fail()
* assert.equal() -> assert.strictEqual()
* replace `exit` handler with `common.mustCall()`

@Trott Trott added net test labels Sep 9, 2016

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 9, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 9, 2016

LGTM

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 10, 2016

Member

LGTM

Member

lpinca commented Sep 10, 2016

LGTM

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Sep 10, 2016

Contributor

LGTM, if CI is happy.

Contributor

thefourtheye commented Sep 10, 2016

LGTM, if CI is happy.

@lpinca

This comment has been minimized.

Show comment
Hide comment
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 10, 2016

Member

Only CI failure is unrelated, will open a new issue.

Member

Trott commented Sep 10, 2016

Only CI failure is unrelated, will open a new issue.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 12, 2016

Member

LGTM

Member

jasnell commented Sep 12, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Sep 13, 2016

test: refactor test-net-pipe-connect-errors
* var -> const
* try/catch -> assert.throws()
* assert.ok(fail) -> common.fail()
* assert.equal() -> assert.strictEqual()
* replace `exit` handler with `common.mustCall()`

PR-URL: nodejs#8473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 13, 2016

Member

Landed in bf0a274

Member

Trott commented Sep 13, 2016

Landed in bf0a274

@Trott Trott closed this Sep 13, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

test: refactor test-net-pipe-connect-errors
* var -> const
* try/catch -> assert.throws()
* assert.ok(fail) -> common.fail()
* assert.equal() -> assert.strictEqual()
* replace `exit` handler with `common.mustCall()`

PR-URL: #8473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment