New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: make v8-bench.js output consistent #8564

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@bzoz
Contributor

bzoz commented Sep 16, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

Description of change

This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

cc @nodejs/benchmarking

benchmark: make v8-bench.js output consistent
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.
@AndreasMadsen

This comment has been minimized.

Member

AndreasMadsen commented Sep 16, 2016

LGTM

@jasnell

LGTM

@Trott Trott force-pushed the nodejs:master branch to c5ce7f4 Sep 21, 2016

@jasnell

This comment has been minimized.

Member

jasnell commented Sep 22, 2016

@nodejs/benchmarking ... comments?

@gareth-ellis

This comment has been minimized.

Member

gareth-ellis commented Sep 22, 2016

Consistency is always a good thing. LGTM

bzoz added a commit that referenced this pull request Sep 26, 2016

benchmark: make v8-bench.js output consistent
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
PR-URL: #8564
@bzoz

This comment has been minimized.

Contributor

bzoz commented Sep 26, 2016

Landed in 9e5a06e

@bzoz bzoz closed this Sep 26, 2016

jasnell added a commit that referenced this pull request Sep 29, 2016

benchmark: make v8-bench.js output consistent
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
PR-URL: #8564

geek added a commit to geek/node that referenced this pull request Sep 30, 2016

benchmark: make v8-bench.js output consistent
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
PR-URL: nodejs#8564

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment