New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: Remove deprecated/unused function requireRepl. Part of #4642 #8575

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@AdriVanHoudt
Member

AdriVanHoudt commented Sep 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

module

Description of change

Remove deprecated/unused function requireRepl.

@AdriVanHoudt AdriVanHoudt force-pushed the AdriVanHoudt:remove-requireRepl branch Sep 17, 2016

@mscdex

This comment has been minimized.

Contributor

mscdex commented Sep 17, 2016

What's the usage look like in the ecosystem? /cc @ChALkeR

@jasnell

LGTM if ecosystem breakage is limited.

@Trott Trott force-pushed the nodejs:master branch to c5ce7f4 Sep 21, 2016

@ChALkeR ChALkeR self-assigned this Sep 21, 2016

@ChALkeR

This comment has been minimized.

Member

ChALkeR commented Sep 23, 2016

requireRepl[^a-zA-Z] grep: https://gist.github.com/ChALkeR/36c79c1fa5f43d4018b783f3409b3a11

Most of those are lib/module.js copies.

LGTM.

@ChALkeR ChALkeR removed their assignment Sep 23, 2016

@bnoordhuis

LGTM but the commit log needs to conform to the style guide.

@AdriVanHoudt

This comment has been minimized.

Member

AdriVanHoudt commented Sep 23, 2016

@bnoordhuis can you point me in the right direction? Not sure what is wrong with the commit log.

@bnoordhuis

This comment has been minimized.

Member

bnoordhuis commented Sep 23, 2016

See CONTRIBUTING.md in the top-level directory; for example, the first line should be <= 50 characters, links to GH issues should be Refs: or Fixes: tags, etc.

@AdriVanHoudt

This comment has been minimized.

Member

AdriVanHoudt commented Sep 23, 2016

Ah I see, thanks, will update soon

@AdriVanHoudt AdriVanHoudt force-pushed the AdriVanHoudt:remove-requireRepl branch Sep 26, 2016

@AdriVanHoudt AdriVanHoudt force-pushed the AdriVanHoudt:remove-requireRepl branch to cd9db93 Sep 26, 2016

@AdriVanHoudt

This comment has been minimized.

Member

AdriVanHoudt commented Sep 26, 2016

@bnoordhuis I think it is conform now

@jasnell

This comment has been minimized.

jasnell added a commit that referenced this pull request Oct 7, 2016

module: Remove deprecated function requireRepl.
Refs: #4642
PR-URL: #8575
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 7, 2016

Landed in 4d6297f. Thank you!

@jasnell jasnell closed this Oct 7, 2016

@AdriVanHoudt AdriVanHoudt deleted the AdriVanHoudt:remove-requireRepl branch Oct 8, 2016

@jasnell

This comment has been minimized.

Member

jasnell commented Oct 10, 2016

@nodejs/ctc ... any objections to landing this in v7.x?

@AdriVanHoudt

This comment has been minimized.

Member

AdriVanHoudt commented Oct 10, 2016

No 😉

jasnell added a commit that referenced this pull request Oct 10, 2016

module: Remove deprecated function requireRepl.
Refs: #4642
PR-URL: #8575
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment