Join GitHub today
test: enable addons test to pass with debug build #8836
Affected core subsystem(s)
Description of change
Currently when running configure with the --debug option in combination
=== release test ===
Error: ENOENT: no such file or directory, open
This commit allows for the tests to pass even if the configured build
Another CI run as I completely missed the paths in addons.md:
I don't think the change to addon.md is a good one. To a third-party add-on, it doesn't matter (much) if node is built in release or debug mode. You can use a debug mode add-on with a release binary and vice versa.
I assume you made the change because node-gyp defaults to the build mode of the node binary? That's actually one of the things I like least about node-gyp; it's confusing to users and it frequently does the wrong thing, like when the node binary that is used to build the add-on is not the binary that actually loads the add-on.
The issue I was trying to work around was that the generated tests assume the the build is of type Release :
// hello.js const addon = require('./build/Release/addon'); console.log(addon.hello()); // 'world'
and changing this to Debug would cause those generated test to fail. Hope I did not misunderstand you here, that might have been what you meant. This is the first time I've dealt with addons.md and how things are generated, and think I need to look into this a little closer.
I can take a shot tonight at adding this to