Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable addons test to pass with debug build #8836

Closed
wants to merge 4 commits into from

Commits on Sep 28, 2016

  1. test: enable addons test to pass with debug build

    Currently when running configure with the --debug option in combination
    with the tests (./configure --debug && make -j8 test) there are a few
    addon tests that fail with error messages similar to this:
    
    === release test ===
    Path: addons/load-long-path/test
    fs.js:558
      return binding.open(pathModule._makeLong(path), stringToFlags(flags),
    mode);
                     ^
    
    Error: ENOENT: no such file or directory, open
    '/nodejs/node/test/addons/load-long-path/build/Release/binding.node'
        at Object.fs.openSync (fs.js:558:18)
        at Object.fs.readFileSync (fs.js:468:33)
        at Object.<anonymous>
    (/nodejs/node/test/addons/load-long-path/test.js:28:19)
        at Module._compile (module.js:560:32)
        at Object.Module._extensions..js (module.js:569:10)
        at Module.load (module.js:477:32)
        at tryModuleLoad (module.js:436:12)
        at Function.Module._load (module.js:428:3)
        at Module.runMain (module.js:594:10)
        at run (bootstrap_node.js:382:7)
    Command: out/Release/node
    /nodejs/node/test/addons/load-long-path/test.js
    
    This commit allows for the tests to pass even if the configured build
    type is of type debug.
    danbev committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    846da75 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2016

  1. update addons.md to consider the build type

    When running:
    $ rm test/addons/.docbuildstamp
    $ make test/addons/.docbuildstamp
    
    A numder of JavaScript test files are generated. These have hard codes
    paths to build/Release/addons. This commit updates these paths to
    consider the type of build being performed.
    danbev committed Oct 1, 2016
    Configuration menu
    Copy the full SHA
    0c3ddf8 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2016

  1. Revert "update addons.md to consider the build type"

    This reverts commit 0c3ddf8.
    danbev committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    79c407c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c991295 View commit details
    Browse the repository at this point in the history