Add i18n support to Windows Installer, add de-de #888
Conversation
|
Ok, a short recap on what has been discussed so far in the old PR:
|
|
@fhemberger can you rebase to the current v1.x and I'll produce a test build for people to try out |
|
@rvagg Ok, I just rebased it to latest v1.x … keeping fingers crossed |
|
@fhemberger something's up with your branch, it's not reconciling very nicely, I'll try and cherry-pick yours to make a workable branch but you should see if you can sort it out, even if it means checking out a fresh branch from the latest v1.x and cherry-picking your commit into that and force pushing over this one. |
|
I don't have a razor for this yak at the moment, any ideas? suggestions? this is win 2008 btw, not that this should make a difference. |
|
@rvagg, see my original post of this PR:
|
|
Force-pushed branch again using latest |
|
ok, well that's pushing me towards a -1 on this given the setup overhead, our inability to automate setup of windows build machines is enough of a problem as it is perhaps we need to find a way to do some auto-discovery in vcbuild.bat like we do looking for the msvc version (well, used to do) |
|
Maybe you could add an wix variable to make the path to WiStubStg.vbs configurable? In general I really don't like the way multi-language support is pieced together. I don't know anything about wix localization, but is there no more straighforward way then extracting a transforms file from the build product and then patching it in place? |
|
Well, unfortunately, I'm no MSI expert either, so I looked it up in a book about Windows Installers. And that was the recommended way (you can also find the same approach described on some websites). I would highly appreciate it, if someone with a deeper knowledge of the subject could review the installer creation process. |
|
@fhemberger Did you try @piscisaureus I do only know, that this is common practice. |
|
@mathiask88 Works for me as well in Visual Studio 2013. I added it to the PR. @rvagg Would you please be so kind and try your build again? |
mscdex
added
build
|
bumping this one. Maybe land in 2.0? My opinion is that if io.js is going for i18n the installer should stick to this plan even though everybody should be able to click some 'next' buttons but under the circumstance that this PR works reliable. I also think that there is not so much future work to do because the installer does not change that often and there will be always the fallback to English. |
|
Any news on the status of the Windows installer? cc @nodejs/platform-windows |
|
@rvagg Uhm. Should I create a new PR against master? If it makes it easier to land, I could comment out the German version for now and just make sure everything is in place (use variables instead of english texts) if we want to start adding translations. |
|
@fhemberger perhaps, could you refresh us on the state of the requirements here, this still uses WiX right, do we need to install anything else to make this work? |
|
WiX and Windows SDK should be everything you need. |
|
@fhemberger ok, do it against |
|
Ok, created a new PR against |
Updated version of #852 (
see this issue for discussions so far), without the VBScripts contained in the "Windows SDK Components for Windows Installer Developers".To make this PR work, paths to
WiSubStg.vbsandWiLangId.vbshave to be adjusted innodemsi.wixprojto match the location of the Windows SDK on the build machines (should be C:\Program Files\Windows Kits\8.1\bin\x86 or x64).UPDATE: The original PR has been removed by GitHub on my request after removing the two VBScript files from the build process.