Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor contextify #8909

Closed
wants to merge 1 commit into from
Closed

src: refactor contextify #8909

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Oct 3, 2016

Checklist
  • make -j8 test (UNIX) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, vm

Description of change

Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.

@fhinkel
src: refactor contextify
ffc9439 
Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.
@fhinkel fhinkel added the vm Issues and PRs related to the vm subsystem. label Oct 3, 2016
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 3, 2016
@fhinkel
Copy link
Member Author

fhinkel commented Oct 3, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4370/

bnoordhuis
bnoordhuis approved these changes Oct 3, 2016
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have my LGTM if you want it but I consider style changes mostly needless churn.

The readability argument is debatable; I personally don't find redundant type info more readable but different strokes for different folks.

addaleax
addaleax approved these changes Oct 4, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes Oct 6, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyller
Copy link
Member

imyller commented Oct 7, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4417/

@jasnell
Copy link
Member

jasnell commented Oct 7, 2016

It appears unrelated, but there's a bit too much red in that last CI run, trying again: https://ci.nodejs.org/job/node-test-pull-request/4420/

fhinkel added a commit that referenced this pull request Oct 16, 2016
@fhinkel
src: refactor contextify
f7842ad 
Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.

PR-URL: #8909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@fhinkel
Copy link
Member Author

fhinkel commented Oct 16, 2016

Landed in f7842ad

@fhinkel fhinkel closed this Oct 16, 2016
jasnell pushed a commit that referenced this pull request Oct 17, 2016
@fhinkel @jasnell
src: refactor contextify
b2be04a 
Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.

PR-URL: #8909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Member

@fhinkel should this be backported?

@fhinkel
Copy link
Member Author

fhinkel commented Nov 14, 2016

No.

@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fhinkel @imyller @jasnell @MylesBorins @bnoordhuis @addaleax @nodejs-github-bot