New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor contextify #8909

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@fhinkel
Member

fhinkel commented Oct 3, 2016

Checklist
  • make -j8 test (UNIX) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, vm

Description of change

Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.

src: refactor contextify
Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.

@fhinkel fhinkel added the vm label Oct 3, 2016

@fhinkel

This comment has been minimized.

@bnoordhuis

You can have my LGTM if you want it but I consider style changes mostly needless churn.

The readability argument is debatable; I personally don't find redundant type info more readable but different strokes for different folks.

@addaleax

LGTM

@jasnell

jasnell approved these changes Oct 6, 2016

LGTM

@imyller

This comment has been minimized.

@jasnell

This comment has been minimized.

Member

jasnell commented Oct 7, 2016

It appears unrelated, but there's a bit too much red in that last CI run, trying again: https://ci.nodejs.org/job/node-test-pull-request/4420/

fhinkel added a commit that referenced this pull request Oct 16, 2016

src: refactor contextify
Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.

PR-URL: #8909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@fhinkel

This comment has been minimized.

Member

fhinkel commented Oct 16, 2016

Landed in f7842ad

@fhinkel fhinkel closed this Oct 16, 2016

jasnell added a commit that referenced this pull request Oct 17, 2016

src: refactor contextify
Small refactoring to make contextify more readable.
Remove auto and inline FromJust(). Simplify
if statement.

PR-URL: #8909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Nov 11, 2016

@fhinkel should this be backported?

@fhinkel

This comment has been minimized.

Member

fhinkel commented Nov 14, 2016

No.

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment