New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add ctc-review label information #9072

Closed
wants to merge 2 commits into
base: master
from

Conversation

@Trott
Member

Trott commented Oct 13, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

This documents use of the ctc-review label.

@bnoordhuis

LGTM with spelling nit.

by the CTC by logging a GitHub issue. Any Collaborator, CTC member, or the
moderator can bring the issue to the CTC's attention by applying the
`ctc-review` label. If consensus-seeking among CTC members fails for a
particular issue, it mae be added to the CTC meeting agenda by adding the

This comment has been minimized.

@bnoordhuis

bnoordhuis Oct 13, 2016

Member

s/mae/may/

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Oct 13, 2016

I think we should change the label to be closer in color to ctc-agenda -- thoughts?

@jasnell

LGTM

@Trott

This comment has been minimized.

Member

Trott commented Oct 13, 2016

I think we should change the label to be closer in color to ctc-agenda -- thoughts?

No opinion either way from me. I say go for it.
https://help.github.com/articles/creating-and-editing-labels-for-issues-and-pull-requests/

@Trott

This comment has been minimized.

Member

Trott commented Oct 14, 2016

@nodejs/ctc

@ofrobots

LGTM

@rvagg rvagg force-pushed the nodejs:master branch 2 times, most recently to 83c7a88 Oct 18, 2016

@addaleax

SGTM

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Oct 19, 2016

LGTM

On Wed, Oct 19, 2016, 12:30 PM Anna Henningsen notifications@github.com
wrote:

@addaleax approved this pull request.

SGTM


You are receiving this because you are on a team that was mentioned.

Reply to this email directly, view it on GitHub
#9072 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV20txRdkGNhdzePBxfaq5lTfgEepks5q1f9agaJpZM4KVezv
.

@rvagg

This comment has been minimized.

Member

rvagg commented Oct 19, 2016

lgtm

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 19, 2016

LGTM

@jasnell jasnell self-assigned this Oct 19, 2016

jasnell added a commit that referenced this pull request Oct 19, 2016

doc: add ctc-review label information
PR-URL: #9072
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 19, 2016

Landed in add8854

@jasnell jasnell closed this Oct 19, 2016

@Trott Trott removed ctc-agenda labels Oct 19, 2016

jasnell added a commit that referenced this pull request Oct 20, 2016

doc: add ctc-review label information
PR-URL: #9072
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Nov 11, 2016

doc: add ctc-review label information
PR-URL: #9072
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Nov 11, 2016

doc: add ctc-review label information
PR-URL: #9072
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment