Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: TLSSocket emits 'error' on handshake failure #9742

Closed

Commits on Nov 22, 2016

  1. tls: TLSSocket emits 'error' on handshake failure

    Removes branch that would make TLSSocket emit '_tlsError' event if
    error occured on handshake and control was not released, as it was
    never happening.  Added test for tls.Server to ensure it still emits
    'tlsClientError' as expected.
    
    Note that 'tlsClientError' does not exist in the v4.x branch so this
    back-port emits 'clientError' instead.  See also pull request nodejs#4557.
    
    Fixes: nodejs#8803
    PR-URL: nodejs#8805
    Refs: nodejs#4557
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    lekoder authored and bnoordhuis committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    4ab1190 View commit details
    Browse the repository at this point in the history