Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish Translation #1608

Closed
francoFerraguti opened this issue Mar 29, 2018 · 9 comments
Closed

Spanish Translation #1608

francoFerraguti opened this issue Mar 29, 2018 · 9 comments

Comments

@francoFerraguti
Copy link

I've found some issues with the spanish translation:
-Instead of Firmas SHASUMS de los arvhivos de versiones, it should be Firmas SHASUMS de los archivos de versiones
-Instead of Building Node.js from source on supported platforms, it should be Compilando Node.js del código fuente en las plataformas soportadas

@thenishchalraj
Copy link

🥇 This was amazing man.

drzippie added a commit to drzippie/nodejs.org that referenced this issue Apr 16, 2018
fhemberger pushed a commit that referenced this issue Apr 16, 2018
@fhemberger
Copy link
Contributor

/cc @nodejs/nodejs-es Are you okay with the translations?

@vrunoa
Copy link
Contributor

vrunoa commented Apr 29, 2018

@francoFerraguti wouldnt it be better:
Compilando Node.js desde el código fuente en las plataformas soportadas
than
Compilando Node.js del código fuente en las plataformas soportadas

@a0viedo
Copy link
Member

a0viedo commented Apr 30, 2018

@francoFerraguti wouldnt it be better:
Compilando Node.js desde el código fuente en las plataformas soportadas

👍

@fhemberger
Copy link
Contributor

Could someone please submit a PR for the change?

pin3da added a commit to pin3da/nodejs.org that referenced this issue Apr 30, 2018
Add missing translation nodejs#1608
ghost pushed a commit that referenced this issue May 1, 2018
Add missing translation #1608
@ghost
Copy link

ghost commented May 1, 2018

PR is merged, feel free to reopen if needed.

@ghost ghost closed this as completed May 1, 2018
@pin3da
Copy link
Contributor

pin3da commented May 6, 2018

I added the missing translation in #1642, but in the page, the content is still in English. I only changed the content in a markdown file, do I need to do something else?

Thanks (:

@fhemberger
Copy link
Contributor

@pin3da Maybe it's a caching issue on your side, the translation is online:

bildschirmfoto 2018-05-07 um 05 55 21

@pin3da
Copy link
Contributor

pin3da commented May 7, 2018

@fhemberger I just noted that the translation was missing in "index.md" too. I submitted a PR for that: #1646

fhemberger pushed a commit that referenced this issue Jul 14, 2018
* Update site.json

Fix "Typo" 
#1608

* sync locale/es/index.md with the original (#1726)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants