Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working redirect from https://nodejs.org/en/docs/inspector page. #1619

Closed
n-filatov opened this issue Apr 7, 2018 · 6 comments
Closed

Comments

@n-filatov
Copy link

When i follow link https://nodejs.org/en/docs/inspector i get 404 error. But when i follow link https://nodejs.org/en/docs/inspector/ i get redirect on https://nodejs.org/en/docs/guides/debugging-getting-started/ page.

@fhemberger
Copy link
Contributor

Where did you find the first link without the trailing slash? This is indeed wrong (thus the 404) and the redirect was introduced in #1610. So everything works as intended.

@n-filatov
Copy link
Author

I found this link in message when executed node --inspect index.js.

@ckotzbauer
Copy link
Contributor

@n-filatov
Copy link
Author

Yep, i have crated pull request in node repo to fix this url, also think that getting 404 error when u follow link without trailing slash may be confuse somebody.

@fhemberger
Copy link
Contributor

Awesome, thanks. I will also fix the redirect - just in case.

rvagg pushed a commit to nodejs/build that referenced this issue Apr 9, 2018
* nginx: Redirect old inspector docs

Ref: nodejs/nodejs.org#1610

* nginx: Redirect old inspector docs (node executable)

Turns out node was linking to https://nodejs.org/en/docs/inspector.
This fixes the redirect as well.

Ref: nodejs/nodejs.org#1619
@fhemberger
Copy link
Contributor

Redirect is fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants