Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://nodejs.org/ja/ is 404 #6501

Closed
azu opened this issue Mar 21, 2024 · 14 comments
Closed

https://nodejs.org/ja/ is 404 #6501

azu opened this issue Mar 21, 2024 · 14 comments
Labels
i18n Issues/PRs related to the Website Internationalisation

Comments

@azu
Copy link

azu commented Mar 21, 2024

URL:

https://nodejs.org/ja/

Browser Name:

Chrome

Browser Version:

124.0.6356.6

Operating System:

macOS 14.3.1(23D60)

How to reproduce the issue:

  1. Visit https://nodejs.org/ja/
  2. Got 404

Actual

All existing https://nodejs.org/ja/* links have been 404.

Expected

Previously, https://nodejs.org/ja/ shown translated page.

If you not plan to support localization on new website, please redirect to default(english) page.

Examples

My guess is that the https://nodejs.org/ja/download download page is linked to from various websites, tutorials and books, so I don't want it to be a 404.

@AugustinMauroy
Copy link
Contributor

For your information, the page does not exist because it has not been translated.
The question is, should we fallback everything that is /{lang}/... into /en/...?

@AugustinMauroy AugustinMauroy added the i18n Issues/PRs related to the Website Internationalisation label Mar 21, 2024
@okuryu
Copy link
Contributor

okuryu commented Mar 21, 2024

If there is no translated page for the relevant page, a fallback should be implemented that redirects to the English version.

btw, I'm currently working on the translations for redesigned site, but I recognize that there is a separate issue with the incomplete integration with CrowdIn at the moment. correct?

@AugustinMauroy
Copy link
Contributor

I recognize that there is a separate issue with the incomplete integration with CrowdIn at the moment. correct?

CORRECT 😅

So yes you can translate on crowdin and it's will appear on website when crowdin issue will be fix.

cc @ovflowd you're on crowdin issue. Could you valide what I said.

@azu
Copy link
Author

azu commented Apr 2, 2024 via email

@ovflowd
Copy link
Member

ovflowd commented Apr 2, 2024

why? 2024年4月2日(火) 18:45 Claudio W @.>:

Closed #6501 <#6501> as not planned. — Reply to this email directly, view it on GitHub <#6501 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAE2AWKFLKY27AAXHGAJGTY3J443AVCNFSM6AAAAABFA646LGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMZDENJSGM3TEOI . You are receiving this because you authored the thread.Message ID: @.
>
-- ================================== Name : azu Mail : @.*** ==================================

Because this is not a bug. We simply do not have translations yet in Japanese.

@azu
Copy link
Author

azu commented Apr 2, 2024

I am concerned that many dead links are occurring due to this problem.

I think it's not just a translation problem.

@ovflowd
Copy link
Member

ovflowd commented Apr 3, 2024

I am concerned that many dead links are occurring due to this problem.

I think it's not just a translation problem.

That's not our issue. Our sitemap clearly states that these links do not exist. It might take some time for Google to update their search indexes regarding these pages.

I think it's not just a translation problem.

It definitely surely is. What you expect us to render then instead of a 404? The Japanese pages simply do not exist.

@ovflowd
Copy link
Member

ovflowd commented Apr 3, 2024

The only other feasible alternative is that if said page does not exist in said localization to redirect them back to a matching page in English (if exists). Not sure how much the lift would be, but it doesn't change the fact the pages would redirect to something that the audience is not expecting to see.

@azu
Copy link
Author

azu commented Apr 3, 2024

What you expect us to render then instead of a 404? The Japanese pages simply do not exist.

I wrote:

If you not plan to support localization on new website, please redirect to default(english) page.
#6501 (comment)

Many websites/blogs/books have a link to the download page, like "Download from here".
But, user will see 404 page instead of it.
I think that the reader here is a beginner, so there is a high possibility that they will give up downloading.

In this context, It is good that redirect to /en/download/

📝 I found another issue on 404 page like https://nodejs.org/es/download/

Another option:

MDN show original page link if translation is not found.

e.g. https://developer.mozilla.org/ja/docs/Mozilla/Firefox/Releases/125
image

@ovflowd
Copy link
Member

ovflowd commented Apr 3, 2024

Reopening as there's a path forward.

@ovflowd ovflowd reopened this Apr 3, 2024
@yosuke-furukawa
Copy link
Member

I would like to contribute this issue, so I sent a join request for crowdin 5days ago. However I have not received the approve response. Could you check the approval process?

@bmuenzenmeyer
Copy link
Collaborator

We're waiting on crowdin to address some parsing concerns. Before then any translation effort may not go well

@ovflowd
Copy link
Member

ovflowd commented Apr 8, 2024

We're waiting on crowdin to address some parsing concerns. Before then any translation effort may not go well

I believe this issue isn't about Japanese translations but about:

  • Broken links if you go to a non existent language. If you open nodejs.org/xx/ for example, any link becomes broken on the main menu
    • This is probably due it not fallbacking to English as "locale" value, and being undefined
  • We should probably attempt to redirect to the English version of said page, if a pge exists.

I believe these two issues can be fixed directly on our app/[locale]/page.tsx file

@yosuke-furukawa
Copy link
Member

hm, I sent a PR. #6628

I believe this PR does not complete all issues, but it could be better to step forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

No branches or pull requests

6 participants