Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 page should be ready to be updated when Node.js v6 drops. #671

Closed
evanlucas opened this issue Apr 20, 2016 · 19 comments
Closed

ES6 page should be ready to be updated when Node.js v6 drops. #671

evanlucas opened this issue Apr 20, 2016 · 19 comments

Comments

@evanlucas
Copy link
Contributor

Node.js v6.0.0 is in the rc phase. See nodejs/node#5766 for status updates. This will include a jump to v8 5.0. That jump will greatly increase the amount of ES2015 features and we need to update the ES6 page (https://nodejs.org/en/docs/es6/).

@mikeal
Copy link
Contributor

mikeal commented Apr 20, 2016

Should we maybe just start directing people to node.green?

@evanlucas
Copy link
Contributor Author

I thought node.green included some staging flags. We probably do not want to include things that require staging flags IMO

@jasnell
Copy link
Member

jasnell commented Apr 20, 2016

It does, but there is a toggle (barely visible) at the top of the page to turn off the things that require flags. Perhaps we could ask @williamkapke to make that toggle more evident? Or perhaps visually distinguish the things that do require a flag?

@williamkapke
Copy link
Member

see: williamkapke/node-compat-table#1

I will change the colors soon (just swamped at the moment). PR welcome ;)

@evanlucas
Copy link
Contributor Author

ok, I'm +1 for removing the page entirely and linking to node.green if we can get work out the flag issue

@stevemao
Copy link
Contributor

Linking #434

@lpinca
Copy link
Member

lpinca commented Apr 21, 2016

Also linking #653.

@fhemberger
Copy link
Contributor

Linking #488 as well.

@fhemberger
Copy link
Contributor

fhemberger commented Apr 21, 2016

PR is ready: #674.
Requires a redirect of https://nodejs.org/en/docs/es6/ => http://node.green as well: nodejs/build#394

@ChALkeR
Copy link
Member

ChALkeR commented Apr 21, 2016

@fhemberger

Does node.green explain the «shipping»/«staged»/«in progress» status of the features and the --es_staging/--harmony/--harmony-* flags? Afaik it doesn't, and that information is valuable there.

It should be moved somehwere, perhaps to a new page.

@jbergstroem
Copy link
Member

@fhemberger: does this mean we should look at hosting node.green as well?

@jbergstroem
Copy link
Member

My 2c would be to keep it separate.

@benjamingr
Copy link
Member

I think node.green is not a good idea for the page (but is amazing otherwise) because the page should be a lot more reader friendly.

@lpinca
Copy link
Member

lpinca commented Apr 21, 2016

@benjamingr honestly I think that we will end with something very similar to node.green if we continue #434.

@williamkapke
Copy link
Member

FYI, I pushed the gold color & percent changes. I am not opposed to turning it over to the node community... that's what I built it for!

At minimum, I'd like to have contributors/collaborators. ;)

@benjamingr
Copy link
Member

I'm in favor with the direction the PR is taking: keeping the part explaining what ES6 is about and then linking to node.green in the "what ES6 features are supported" part.

I'm also in favor of the foundation taking over node.green and @williamkapke joining the node foundation and maintaining it from within.

@jasnell
Copy link
Member

jasnell commented Apr 23, 2016

I'm not sure I would characterize it as "taking it over" :-) We're more
than happy to give node.green a home here and to help promote it. It's a
fantastic tool and definitely something that's needed.

Question for @williamkapke: how closely does this follow test262?
On Apr 23, 2016 6:21 AM, "Benjamin Gruenbaum" notifications@github.com
wrote:

I'm in favor with the direction the PR is taking: keeping the part
explaining what ES6 is about and then linking to node.green in the "what
ES6 features are supported" part.

I'm also in favor of the foundation taking over node.green and
@williamkapke https://github.com/williamkapke joining the node
foundation and maintaining it from within.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#671 (comment)

@williamkapke
Copy link
Member

how closely does this follow test262

@jasnell All of the tests are pulled from Kangax's project- so I'm not sure. They are quite active at adding/updating/improving the tests. It is all automatic- tests are pulled and run daily.

@williamkapke
Copy link
Member

@jasnell The V8 blog has more info on your question about test262.

Kangax makes it easy to skim to see whether a particular feature (like arrow functions) has been implemented in a given engine, but doesn’t test all the conformance edge cases that test262 does. Currently, Chrome Canary scores a 98% on the Kangax table for ES6 and 100% on the sections of Kangax corresponding to ES7 (e.g. the sections labelled “2016 features” and “2016 misc” under the ESnext tab).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants