Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always translate header & footer templates? #825

Closed
Fishrock123 opened this issue Jul 15, 2016 · 3 comments
Closed

Always translate header & footer templates? #825

Fishrock123 opened this issue Jul 15, 2016 · 3 comments
Labels
i18n Issues/PRs related to the Website Internationalisation

Comments

@Fishrock123
Copy link
Member

I'm not sure this is feasible, but maybe we should build all possible pages that exist from en in every language using the localized templates (header, footer, etc), and use those pages as the fall-backs rather than the actual english pages.

This has two obvious downsides, beyonds complexity:

  1. Build times would be dramatically increased.
  2. Build output size.

Perhaps a bit more involved, maybe we can get nginx to serve some sort of partials where we concat the header to the body directly during serving? Is that even possible? I have no idea.

@Fishrock123 Fishrock123 added discuss i18n Issues/PRs related to the Website Internationalisation labels Jul 15, 2016
@phillipj
Copy link
Member

This has two obvious downsides, beyonds complexity:

  1. Build times would be dramatically increased.
  2. Build output size.
  1. Mostly an issue when developing locally. Could be less of an issue if we made it possible to specify which locale to build.
  2. With the current set of locales, it would have increased the total build size from ~26MB -> 58MB. Still pretty low figure IMO.

Perhaps a bit more involved, maybe we can get nginx to serve some sort of partials where we concat the header to the body directly during serving? Is that even possible? ..

Server Side Includes could be an option if we want to go down this route... http://nginx.org/en/docs/http/ngx_http_ssi_module.html

@ZYSzys
Copy link
Member

ZYSzys commented Jan 20, 2019

I'm not sure this is feasible, but maybe we should build all possible pages that exist from en in every language using the localized templates (header, footer, etc), and use those pages as the fall-backs rather than the actual english pages.

If I'm not wrong, the PR #1940 has implemented this now.

@fhemberger
Copy link
Contributor

Yes, it did. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

No branches or pull requests

4 participants