Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove events page #1314

Merged
merged 1 commit into from Aug 8, 2017
Merged

Remove events page #1314

merged 1 commit into from Aug 8, 2017

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jul 26, 2017

This removes the event pages as per #1031.
The diff is big but it should be easy to review :)

@fhemberger
Copy link
Contributor

Thought we would keep the page (for conferences and Nodeschool events) and just remove the Meetups?

@amandeepmittal
Copy link
Contributor

I agree with @fhemberger with removing the meetups and keeping the page.

@lpinca
Copy link
Member Author

lpinca commented Jul 28, 2017

I'm fine with that but then we should update them regularly. I agree with what @Trott wrote here: #1031 (comment).

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnb
Copy link
Contributor

bnb commented Aug 7, 2017

Saw this issue, and logged it in nodejs/community-events#2. That issue there shouldn't be a blocker to this PR, but did want to raise the potential there for people to start getting involved at a future date, should they be interested 👍

@Trott
Copy link
Member

Trott commented Aug 7, 2017

Not sure how exactly the process works here these days. Can this land? Or is this blocked by objections?

@fhemberger
Copy link
Contributor

@Trott We are thinking about keeping some kind of events list, but without the map and the list from meetup.com. Sorry, didn't have time to look into it yet.

@fhemberger fhemberger merged commit 708f58f into master Aug 8, 2017
@fhemberger fhemberger deleted the remove/events-page branch August 8, 2017 06:36
@fhemberger
Copy link
Contributor

@Trott Okay, we can come up later with a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants