Remove 'v' from displayed Node.js versions #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other components like npm, v8, etc. don't have this prefix.
|
Code looks good to me but I'm not sure if we should remove the leading |
gibfahn
approved these changes
Oct 4, 2017
|
SGTM for reasons stated in #1246 (comment) |
|
I have no strong opinions, |
?
|
Okay, no veto from anyone, so |
This was referenced Mar 7, 2024
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js versions are the only ones (historically) prefixed with a 'v', contrary to other included components like npm or v8.
As the content of
versions.jsonis used on multiple occasions and I didn't want to break any functionality requiring the prefix (e.g. download links), I added a new Handlebars helper to remove the prefix where needed.At the moment, this is implemented on the home page, download page headline and the revision list.
Fixes #1246.