Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make homepage banner translatable #1525

Merged
merged 2 commits into from Dec 22, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.js
Expand Up @@ -270,7 +270,7 @@ function getSource (callback) {
},
banner: {
visible: true,
content: 'Important <a href="https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/">security releases</a>, please update now!'
link: 'https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/'
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion layouts/index.hbs
Expand Up @@ -14,7 +14,7 @@

{{#if project.banner.visible}}
<p class="home-version home-version-banner">
{{{ project.banner.content }}}
<a href="{{ project.banner.link }}">{{{ labels.banner }}}</a>
</p>
{{/if}}

Expand Down
1 change: 1 addition & 0 deletions locale/ca/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: Versió actual
download: Descarregar
download-for: Descarregar per
Expand Down
1 change: 1 addition & 0 deletions locale/de/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Wichtige Sicherheits-Updates, bitte aktualisieren Sie jetzt!
current-version: Aktuelle Version
download: Download
download-for: Herunterladen für
Expand Down
1 change: 1 addition & 0 deletions locale/en/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: Current Version
download: Download
download-for: Download for
Expand Down
1 change: 1 addition & 0 deletions locale/es/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: Versión Actual
download: Descargar
download-for: Descargar para
Expand Down
1 change: 1 addition & 0 deletions locale/fr/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it saves a PR, I think we could go with:
"Mises à jour de sécurité importantes, veuillez mettre à jour!"
@nodejs/nodejs-fr Ca me semble redondant. D'autres idées?

current-version: Version actuelle
download: Téléchargements
download-for: Téléchargements pour
Expand Down
1 change: 1 addition & 0 deletions locale/gl/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: Versión Actual
download: Descargar
download-for: Descargar para
Expand Down
1 change: 1 addition & 0 deletions locale/it/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: Versione corrente
download: Download
download-for: Download per
Expand Down
1 change: 1 addition & 0 deletions locale/ja/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: 最新のバージョン
download: ダウンロード
download-for: ダウンロード
Expand Down
1 change: 1 addition & 0 deletions locale/ko/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: 현재 버전
download: 다운로드
download-for: 다운로드 -
Expand Down
1 change: 1 addition & 0 deletions locale/uk/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: Поточна версія
download: Завантажити
download-for: Завантажити для
Expand Down
1 change: 1 addition & 0 deletions locale/zh-cn/index.md
@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
current-version: 当前版本
download: 下载
download-for: 下载为
Expand Down