-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] Fix some Chinese translations #1686
Conversation
其他
/cc @nodejs/nodejs-cn |
locale/zh-cn/index.md
Outdated
other-lts-downloads: 其他 LTS 下载 | ||
other-current-downloads: 其他最新版本下载 | ||
other-downloads: 其它下载 | ||
other-lts-downloads: 其它LTS版下载 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you have spaces between CJK and ASCII chararcters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fixed.
PS: Why? The formation recognization?
locale/zh-cn/index.md
Outdated
@@ -17,8 +17,8 @@ labels: | |||
version-schedule-prompt: 可参考 | |||
version-schedule-prompt-link-text: LTS 日程。 | |||
newsletter: true | |||
newsletter-prefix: 注册 | |||
newsletter-postfix: ", Node.js 官方的新闻周报。" | |||
newsletter-prefix: 注册订阅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you may just remove 注册.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Fixed
Good job, thank you! |
The original issue reported here: #1685
You're welcome! All things have all been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Logs:
其他
to其它
。Sign up for
doesn't mean注册
. It means报名登记
、参与……
. According to the context,注册订阅
is a right meaning.