Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Translate For all the files in zh-CN\get-involved #1713

Merged
5 commits merged into from Aug 25, 2018
Merged

[Localization] Translate For all the files in zh-CN\get-involved #1713

5 commits merged into from Aug 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2018

All the files there are totally completed into Chinese.

@fhemberger
Copy link
Contributor

/cc @nodejs/nodejs-cn

@ghost ghost self-assigned this Jul 9, 2018
@fhemberger
Copy link
Contributor

@nodejs/nodejs-cn Could you please review this PR so we can merge it? Thank you!

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

layout: contribute.hbs
---

# 协作者峰会
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


# 我们鼓励来自社区的各种贡献

Node.js 是个包容的大家庭,因此我们鼓励用户各施所长。 若你想 [汇报问题](https://github.com/nodejs/node/issues) 或者 [协助编辑文件及贡献代码](/zh-tw/get-involved/contribute/),那就来对地方了,看看下列的社区资源是不是能帮到你:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zh-tw in link

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

layout: contribute.hbs
---

# 代码 + 学习
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'Code' is a verb. 编码 may be better.


## 已经结束的代码 + 学习活动

- [Oakland on April 22, 2017](https://medium.com/the-node-js-collection/code-learn-learn-how-to-contribute-to-node-js-core-8a2dbdf9be45)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017-04-22,美国奥克兰

Copy link
Author

@ghost ghost Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs translating these addresses, locations……ect. Please refer 'zh-TW', 'uk' 's translations.

## 已经结束的代码 + 学习活动

- [Oakland on April 22, 2017](https://medium.com/the-node-js-collection/code-learn-learn-how-to-contribute-to-node-js-core-8a2dbdf9be45)
- Shanghai at JSConf.CN: July 2017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017-07,上海 JSConfCN may be better?

Copy link
Author

@ghost ghost Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs translating these addresses, locations……ect. Please refer 'zh-TW', 'uk' 's translations.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants