Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-TW:Add missing trans #2164

Merged
1 commit merged into from Apr 2, 2019
Merged

zh-TW:Add missing trans #2164

1 commit merged into from Apr 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2019

The title of 'collab-summit.md' seems missing of translation, so we've added up for that.

The title of 'collab-summit.md' seems missing of translation, so we've
added up for that.
@ghost ghost requested a review from osk2 April 1, 2019 02:19
@osk2
Copy link
Contributor

osk2 commented Apr 1, 2019

I left this untranslated intentionally.
I'm fine with this but I will leave it to others to decide :)

@dca
Copy link
Contributor

dca commented Apr 1, 2019

LGTM

@ghost
Copy link
Author

ghost commented Apr 1, 2019

@osk2:I tend to translate all things that can be translated to keep the pure translation if possible —— what's more:to be the same as what it is given in the content of your article.

@ghost
Copy link
Author

ghost commented Apr 1, 2019

@nodejs/nodejs-tw:Please have a review if possible, if more than one agrees with my changes, I'll submit it :)

@dca dca self-requested a review April 1, 2019 05:31
@mingtsay
Copy link

mingtsay commented Apr 1, 2019 via email

@ghost
Copy link
Author

ghost commented Apr 1, 2019

@mingtsay:Sorry but to tell you the truth, I don't think it good to mix the Chinese words with English ones……XD

@osk2
Copy link
Contributor

osk2 commented Apr 1, 2019

People who visit Node.js website should have no problem to understand what "Collab Summit" is. That's why I left it untranslated in the first place.

I also agree with @Maledong. I'll just choose one of "Collab Summit" or "協作者峰會" to prevent confusing readers.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants