Tighten stylint config. #2406
Merged
Tighten stylint config. #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready. First #2394 should be merged and I'll rebase this. |
XhmikosR
commented
Aug 15, 2019
| } | ||
| }, | ||
| "leadingZero": { | ||
| "expect": "always", |
There was a problem hiding this comment.
Personally I'd use never here, but most cases were using a leading 0 so I went with always.
alexandrtovmach
approved these changes
Aug 16, 2019
|
Please note that #2394 should be merged first. |
Aissaoui-Ahmed
approved these changes
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, I'll try to find the config that matches the current style best so that we don't need to make many changes in the source files.
Fixes #2404