Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS tweaks. #2620

Closed
wants to merge 1 commit into from
Closed

CSS tweaks. #2620

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 29, 2019

  • switch to rems (mostly for font-size for now)
  • move a few selectors outside of styles.scss
  • add margin-bottom in header logo so that there's more room for tap targets

I still think many font-sizes are too small, but this should be tackled separately. In this PR, I tried to keep things consistent with what it was.

Preview: https://youthful-nightingale-b83864.netlify.com/en/

Note that this will conflict with #2530 but the Sass switch should probably come first.

Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with Stylelint to tell if rem can be enforced https://github.com/stylelint/stylelint/blob/master/docs/user-guide/configuration.md#rules

layouts/css/_utils.scss Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Contributor Author

I could only find https://github.com/meowtec/stylelint-no-px but I don't know if it's worth bothering with it now. You are welcome to try it after this lands :)

* switch to `rem`s (mostly for font-size for now)
* move a few selectors outside of styles.scss
* add `margin-bottom` in header logo so that there's more room for tap targets
@XhmikosR
Copy link
Contributor Author

I'm gonna drop this for now. We are still blocked by nodejs/build#1947

I might do some of the changes that don't affect the final CSS in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants