Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: thanking contributor (#2632) #2635

Merged
merged 10 commits into from
Jan 31, 2020
Merged

feat: thanking contributor (#2632) #2635

merged 10 commits into from
Jan 31, 2020

Commits on Jan 20, 2020

  1. feat: contributor card

    @KeziahMoselle @XhmikosR
    KeziahMoselle authored and XhmikosR committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    a1e2a3c View commit details
    Browse the repository at this point in the history

  2. More progress 

    * return early
* hide the block by default
* remove function used only once
* remove `height: 0`
* add dns-prefetch for api.github.com
    @XhmikosR
    XhmikosR committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    5a4ab2e View commit details
    Browse the repository at this point in the history

  3. More progress 

    * fix: check for the card instead of the avatar
* feat: add intersection observer support
* feat: localstorage caching
  - set 2 keys : max_contributors and fetch_date
  - if max_contributors is set : refetch max contributors
  - if fetch_date is 1 month old : refetch max contributors
  - if max_contributors is set and fetch_date is less that one month old : fetch only the contributor
* feat: style contributor card, avatar and contributions links
* feat: loading spinner
* feat: handle requests error by removing the card
    @KeziahMoselle @XhmikosR
    KeziahMoselle authored and XhmikosR committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    a8065f5 View commit details
    Browse the repository at this point in the history

  4. Use addEventListener and remove redundant assignment

    @XhmikosR
    XhmikosR committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    d70fee6 View commit details
    Browse the repository at this point in the history

  5. fix: rel nofollow, textcontent, image parameter, text wrapping

    @KeziahMoselle @XhmikosR
    KeziahMoselle authored and XhmikosR committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    aa06d21 View commit details
    Browse the repository at this point in the history

  6. More tweaks and fix IE >= 10 JS. 

    Also, move `.hidden` to utils.
    @XhmikosR
    XhmikosR committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    3edc273 View commit details
    Browse the repository at this point in the history

  7. IE fixes

    @MartijnCuppens @XhmikosR
    MartijnCuppens authored and XhmikosR committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    edbae36 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2020

  1. Merge branch 'master' into feat-thanking-contributors

    @Wai-Dung
    Wai-Dung committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    3df89e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. Merge branch 'master' into feat-thanking-contributors

    @Wai-Dung
    Wai-Dung committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    53dd1bf View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. Merge branch 'master' into feat-thanking-contributors

    @XhmikosR
    XhmikosR committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    0784233 View commit details
    Browse the repository at this point in the history