Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de: add missing strings #3848

Merged
merged 2 commits into from
May 3, 2021
Merged

de: add missing strings #3848

merged 2 commits into from
May 3, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 3, 2021

There are probably more, I just noticed these, so I went with the English strings. I believe it's better than having missing text...

@XhmikosR XhmikosR marked this pull request as ready for review May 3, 2021 07:10
Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if these would just "fallback", but probably better to include for the translators to flag that they're missing

@XhmikosR
Copy link
Contributor Author

XhmikosR commented May 3, 2021

The only fallback we currently have is if a whole file is missing. So, in all other cases, strings will not be in sync.

Anyway, if anyone spots more like these, we should fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants