Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code typo fix #4992

Closed
wants to merge 5 commits into from
Closed

code typo fix #4992

wants to merge 5 commits into from

Conversation

Olympicene
Copy link

added missing comma to myOptions object value

@AugustinMauroy
Copy link
Contributor

AugustinMauroy commented Jan 4, 2023 •
edited by ovflowd

Have you looked at the translated files? (There are other folders containing the same file)

edited by @ovflowd

@ovflowd

This comment was marked as off-topic.

Sign in to view
@AugustinMauroy

This comment was marked as off-topic.

Sign in to view
@ovflowd

This comment was marked as off-topic.

Sign in to view
@ovflowd

This comment was marked as off-topic.

Sign in to view
@AugustinMauroy

This comment was marked as off-topic.

Sign in to view
ItaloPussi
ItaloPussi suggested changes Jan 5, 2023
View reviewed changes
Copy link

@ItaloPussi ItaloPussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking other locales, I found out that FR and PT-BR has the same mistake in the same file. Could you fix it to centralize these corrections in this pull request?

@Olympicene
Copy link
Author

Got it. Added missing commas to FR and PT-BR.

ItaloPussi
ItaloPussi approved these changes Jan 5, 2023
View reviewed changes
Copy link

@ItaloPussi ItaloPussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me :)

ItaloPussi
ItaloPussi approved these changes Jan 5, 2023
View reviewed changes
Copy link

@ItaloPussi ItaloPussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me :)

AugustinMauroy
AugustinMauroy approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!!!!

shanpriyan
shanpriyan approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nschonni
Copy link
Member

Thanks for the fix. Closing because #4999 was landed and removed these files

@nschonni nschonni closed this Jan 12, 2023
@ryan-ally ryan-ally mentioned this pull request Jun 20, 2023
Open
@adamlaska adamlaska mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymen94 aymen94 aymen94 approved these changes

@ItaloPussi ItaloPussi ItaloPussi approved these changes

@shanpriyan shanpriyan shanpriyan approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Olympicene @AugustinMauroy @ovflowd @nschonni @aymen94 @ItaloPussi @shanpriyan