Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate: Source-link #5364

Merged
merged 4 commits into from May 18, 2023

Conversation

yossipoli
Copy link
Contributor

@yossipoli yossipoli commented May 7, 2023

Description

Migrate source link from gatsby to next

Related Issues

Issue #5309

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented May 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ❌ Failed (Inspect) May 18, 2023 9:31pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview May 18, 2023 9:31pm

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 7, 2023 20:39 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 7, 2023 20:41 Inactive
i18n/locales/en.json Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 9, 2023 20:25 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 9, 2023 20:25 Inactive
@AugustinMauroy
Copy link
Contributor

Have you found an usage of this component on nodejs.dev to see how it's use and if it's good ?

@yossipoli
Copy link
Contributor Author

Have you found an usage of this component on nodejs.dev to see how it's use and if it's good ?

Yes.
The component used in the ApiComponent:
https://github.com/nodejs/nodejs.dev/blob/5a66d4102570ac8693a927b5ed2b440967fb29d3/src/components/ApiComponents/index.tsx#L16

@AugustinMauroy
Copy link
Contributor

Hum I mean have you found an usage in an page

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good! @yossipoli could you run test:storybook:snapshot to generate the snapshots of your stories?

I super appreciate your first time contribution! Thank you!!

@vercel vercel bot temporarily deployed to Preview – nodejs-org May 12, 2023 13:45 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 12, 2023 13:46 Inactive
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel
Copy link

vercel bot commented May 18, 2023

@ovflowd is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 18, 2023 21:26 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 18, 2023 21:31 Inactive
@ovflowd ovflowd merged commit c254c60 into nodejs:major/website-redesign May 18, 2023
7 of 8 checks passed
ovflowd added a commit that referenced this pull request May 24, 2023
* Migrate: Source-link

* Fix: JSON key moved to the end of the file

* Test: Storybook snapshot test

---------

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
ovflowd added a commit that referenced this pull request May 24, 2023
* Migrate: Source-link

* Fix: JSON key moved to the end of the file

* Test: Storybook snapshot test

---------

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants