Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configuration for merge queues #5592

Merged
merged 2 commits into from
Aug 2, 2023
Merged

chore: configuration for merge queues #5592

merged 2 commits into from
Aug 2, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Aug 1, 2023

Description

As I'm discussing with @bmuenzenmeyer we're thinking in using merge queues to reduce the noise of merge commits and etc on PRs.

This PR updates our GitHub Actions to be compatible with Merge Queues

cc @bmuenzenmeyer

@ovflowd ovflowd requested a review from a team as a code owner August 1, 2023 08:43
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Aug 1, 2023 8:43am

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.42% (366/396) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 11.292s ⏱️

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read through the merge queue docs a couple times and am excited to try this out!

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Aug 2, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Aug 2, 2023

cc @nodejs/website fast-tracking this as this should be a simple enough change? React with 👍 for approval!

@ovflowd ovflowd merged commit 099470b into main Aug 2, 2023
12 checks passed
@ovflowd ovflowd deleted the meta/merge-queues branch August 2, 2023 11:05
@ovflowd
Copy link
Member Author

ovflowd commented Aug 2, 2023

Merge Queues Enabled! (And Enforced on main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants