Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: main download button for linux incorrect #5618

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Aug 9, 2023

Description

Fixes #5610 - the download button for Linux on the front page of the website links to the source tar archive, not the built node.js for that platform as it should.

Validation

Main download link is for the binary, not the source, when connecting from a Linux web browser.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa requested a review from a team as a code owner August 9, 2023 09:30
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 9:49am

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.42% (366/396) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 9.985s ⏱️

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@sxa sxa marked this pull request as draft August 9, 2023 09:34
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me :) (Feel free to test on the Deployment Preview URL)

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa
Copy link
Member Author

sxa commented Aug 9, 2023

Preview looks good. Note that this is currently hard coded to provide the Linux/x64 download when a Linux web browser is detected, however this is consistent with the label displayed above the buttons which will always display (X64) for the architecture as per

return ` Linux (x64)`;

The architecture detection would require more work so this should be considered a first phase of the solution.

@sxa sxa marked this pull request as ready for review August 9, 2023 10:20
@ovflowd
Copy link
Member

ovflowd commented Aug 9, 2023

The architecture detection would require more work so this should be considered a first phase of the solution.

Yeah, we have plans of better arch detection, the main reason it is the way it is is because in the past only these 3 platforms were considered. On the redesigns we're aiming for a broader range.

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Aug 9, 2023
@ovflowd
Copy link
Member

ovflowd commented Aug 9, 2023

I'm fast-tracking this due to the nature of being a super simple change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big green download button on nodejs.org from Linux/x64 gives source archive
2 participants