Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the nodejs-black.png file Issue #5823 #5844

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

nathaliaAlmeidaProfile
Copy link
Contributor

@nathaliaAlmeidaProfile nathaliaAlmeidaProfile commented Sep 22, 2023

Description

File is no longer used and can be deleted.
First pull request for GHC OSD

Validation

First pull request for GHC OSD

Related Issues

Fixes #5823

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 6:49pm

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Nathalia! Super appreciate your first contribution 🎉 ✨

ovflowd

This comment was marked as duplicate.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 4.457s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Sep 22, 2023

Hey @nathaliaAlmeidaProfile I've noticed you added another file to this PR, was that intentional? 👀

You might want to tackle the other file deletion on another PR! But this one is fine too :)

@bmuenzenmeyer
Copy link
Collaborator

this i think is the last deletion - i was worried about overlap with the two files but seein none, i think it can move forward

@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Sep 23, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 23, 2023
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 23, 2023
Merged via the queue into nodejs:main with commit 6d3468c Sep 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete the nodejs-black.png file
3 participants