New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Download layout #6353
feat: Download layout #6353
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking amazing!
functional review
small state bug, three way dropdown can create impossible combinations. for example:
- go to https://nodejs-org-git-fork-canerakdas-download-layout-openjs.vercel.app/en/download
- choose
v20.11.1
(default),Windows
,ARM64
- downloads successfully
- switch ONLY version to
17.9.1
- download buttons gives me an nginx 404 https://nodejs.org/dist/v17.9.1/node-v17.9.1-arm64.msi
the UI knows that this is not a valid option to choose
but since it was already on ARM, it doesn't prevent the action
is linux available on any version or chip?
perhaps my machine is preventing me from choosing it (but it doesnt prevent Mac downloads on a Windows device)
There is no Installer for Linux. Just Prebuilt Binaries
Will work on fixing it |
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
I've fixed the BitnessDropdown issue, forgot to apply the same logic. Thanks for the diligence, @bmuenzenmeyer |
Since this is a big PR and we know getting more reviews will probably be more challenging, me and @bmuenzenmeyer decided to merge this as it is. We can always iterate on further fixes :) |
Description
This is a draft PR and missing features need to be added before it is ready for review. The output of this PR includes the following pages and Download Layout;
/download
/download/current
/download/source-code
/download/source-code/current
/download/package-manager
/download/package-manager/current
Feel free to leave any pre-comments / commits @nodejs/nodejs-website
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.