Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Download layout #6353

Merged
merged 37 commits into from Feb 25, 2024
Merged

feat: Download layout #6353

merged 37 commits into from Feb 25, 2024

Conversation

canerakdas
Copy link
Member

@canerakdas canerakdas commented Feb 19, 2024

Description

This is a draft PR and missing features need to be added before it is ready for review. The output of this PR includes the following pages and Download Layout;

  • /download
  • /download/current
  • /download/source-code
  • /download/source-code/current
  • /download/package-manager
  • /download/package-manager/current

Feel free to leave any pre-comments / commits @nodejs/nodejs-website

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2024 6:39pm

Copy link

github-actions bot commented Feb 23, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 98 🟠 83 🟢 91 🔗
/en/about 🟢 100 🟢 91 🟠 83 🟠 83 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟠 83 🟢 92 🔗
/en/download 🟢 99 🟢 97 🟠 83 🟢 91 🔗
/en/blog 🟢 97 🟢 96 🟠 83 🟢 92 🔗

Copy link

github-actions bot commented Feb 23, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.07% (438/547) 79.09% (140/177) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.403s ⏱️

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking amazing!

functional review

small state bug, three way dropdown can create impossible combinations. for example:

  1. go to https://nodejs-org-git-fork-canerakdas-download-layout-openjs.vercel.app/en/download
  2. choose v20.11.1 (default), Windows, ARM64

image

  1. downloads successfully
  2. switch ONLY version to 17.9.1

image

  1. download buttons gives me an nginx 404 https://nodejs.org/dist/v17.9.1/node-v17.9.1-arm64.msi

the UI knows that this is not a valid option to choose

image

but since it was already on ARM, it doesn't prevent the action

is linux available on any version or chip?

perhaps my machine is preventing me from choosing it (but it doesnt prevent Mac downloads on a Windows device)

components/Downloads/Release/BitnessDropdown.tsx Outdated Show resolved Hide resolved
components/Downloads/Release/OperatingSystemDropdown.tsx Outdated Show resolved Hide resolved
components/Downloads/Release/PlatformDropdown.tsx Outdated Show resolved Hide resolved
components/Downloads/Release/PlatformDropdown.tsx Outdated Show resolved Hide resolved
components/Downloads/Release/ReleaseCodeBox.tsx Outdated Show resolved Hide resolved
components/Icons/Platform/Docker.tsx Outdated Show resolved Hide resolved
util/getNodeDownloadSnippet.ts Show resolved Hide resolved
@ovflowd
Copy link
Member

ovflowd commented Feb 25, 2024

is linux available on any version or chip?
perhaps my machine is preventing me from choosing it (but it doesnt prevent Mac downloads on a Windows device)

There is no Installer for Linux. Just Prebuilt Binaries

but since it was already on ARM, it doesn't prevent the action

Will work on fixing it

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 25, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 25, 2024
@ovflowd
Copy link
Member

ovflowd commented Feb 25, 2024

I've fixed the BitnessDropdown issue, forgot to apply the same logic. Thanks for the diligence, @bmuenzenmeyer

@ovflowd
Copy link
Member

ovflowd commented Feb 25, 2024

Since this is a big PR and we know getting more reviews will probably be more challenging, me and @bmuenzenmeyer decided to merge this as it is.

We can always iterate on further fixes :)

@ovflowd ovflowd added this pull request to the merge queue Feb 25, 2024
Merged via the queue into nodejs:main with commit b624417 Feb 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design website redesign Issue/PR part of the Node.js Website Redesign
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants