Redesign updates #6369
Redesign updates #6369
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A rebase is needed here to make the build pass 👀 |
|
I'm having trouble seeing what you're trying to solve. But if it's the hover effect on the header. I think you should use the same hover effect as in the footer. It would look better because the green hover is a bit aggressive. |
|
in general, how do we go about deciding if this, or any future change, is adherent to our design vision? |
PickleNik
force-pushed
the
redesign-updates
branch
from
edd288d
to
8322211
Compare
|
Rebased, I made it green with transparency to match the hue of what active navlink background color is. But I can change it to what the footer does. Another idea I had is to just make them underline on hover. |
Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: PickleNik <31113245+PickleNik@users.noreply.github.com>
Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: PickleNik <31113245+PickleNik@users.noreply.github.com>
|
another thing to note, it's the same effect (grey button) as on the buttons for language, theme, rss feed (on the blog page) |
|
To be honest, I don't think we need a hover effect on the Navigation. I would say at max, just change the text colour to either darker or lighter and ensure they look good on both themes |
|
I like the idea of playing with the color of the text. It's simple, but it shows that the element is interactive. |
|
It looks like the author abandoned the PR. |
|
yeah my bad, I'll open a new one in spare time |
|
No worries! Appreciate the forthcoming! |
before
Screen.Recording.2024-02-29.at.11.24.36.AM.mov
after
Screen.Recording.2024-02-29.at.11.24.51.AM.mov