Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commitizen to repo to make it easy to follow conventional-commits #6844

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

rikhall1515
Copy link
Contributor

Description

This makes it so that you only need to run 'git commit' in order to get conventional-commit compliant commits.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

This makes it so that you only need to run 'git commit' in order to get conventional-commit
compliant commits.
@rikhall1515 rikhall1515 requested review from a team as code owners June 18, 2024 20:14
Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 18, 2024 8:16pm

@rikhall1515
Copy link
Contributor Author

rikhall1515 commented Jun 18, 2024

This is a re-open of #6659 so I'm just currently waiting on this getting approved. Now this PR just has one single commit.

Copy link

github-actions bot commented Jun 19, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 86 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.192s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd
Copy link
Member

ovflowd commented Jun 19, 2024

Thanks for your patience here and for iterating on this PR!

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jun 19, 2024

The most critical workflow I want to ensure we don't change is the blog post release process. Has anyone tested that yet?

edit: Marco said this would not affect him

@ovflowd
Copy link
Member

ovflowd commented Jun 21, 2024

Alrighty, I believe we can merge this. If issues eventually rise, we can just revert and investigate :)

@ovflowd ovflowd added this pull request to the merge queue Jun 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jun 21, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@ovflowd ovflowd merged commit a6cde27 into nodejs:main Jun 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants