Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update introduction-to-nodejs.md #6859

Closed
wants to merge 1 commit into from

Conversation

PremKaneriya
Copy link

@PremKaneriya PremKaneriya commented Jun 22, 2024

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: pre-dev <118497454+PremKaneriya@users.noreply.github.com>
@PremKaneriya PremKaneriya requested a review from a team as a code owner June 22, 2024 05:47
Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 22, 2024 5:49am

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'm not sure this change is necessary. The original phrasing is clear and concise. I don't think the superhero analogy is adding much here.

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 for theses changes, this reduces the clarity of the text.
"keep it simple"

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jun 22, 2024

Phase refer to the issue log if you are interested in furthering project goals. An opinionated, unsolicited content change like this only causes maintainer noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants