fix: make the searchButton width dynamic to fit the content
#6904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mikeal, @AugustinMauroy, could you do the honour of reviewing and merging this pull request, please? |
|
With these changes, the issue still occurs for viewport 1030. 
|
This is something else, not related to this issue. There's just literally no enough space to render things here. |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage ReportUnit Test Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6903
closes #6841
Description
In this pull request, I am solving the problem I figured out and reported on #6903 (now closed) and #6841 issue. It's a simple solution with a great visual impact on the issue, and finally, the solution works correctly on all idioms of the website.
Validation
Related Issues
searchButtoncomponent breaks visually on portuguese website. #6903Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.