Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update with recommended integration into package.json #281
doc: update with recommended integration into package.json #281
Changes from 1 commit
ca4933a
2f87597
db2e4d4
c19d197
0cf84af
a7ff367
3d7fab0
5202e44
9a0d022
269c487
0474af3
7f4b09c
5bfa45a
bdbc12b
03c24f9
4c64772
3d8dcd2
c92a598
14dd469
f5ec57b
1f1b798
8755f22
eac1747
506ce31
feb7d73
53b0598
d679c6f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove the hard-wrapping throughout the doc? it's easier to review and suggest when arbitrary newlines aren't inserted all over the place :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnmuhl why the thumbs down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a subjective thing, which I am guessing causes the thumbs down. Depending on your editor and configuration, these newlines can make this document legible where otherwise it would not be. In this particular line it might not matter, but I know sometimes when I have vim open on a wide screen, a long single line paragraph is painful to read. Just my 2c.
EDIT: I am not saying it should be one way or another, I just wanted to point out it is heavily subjective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but the GitHub UI always wraps by default, and suggestions are single line, and vim/editors can easily be configured to soft wrap if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(it'd be nicer to review if these weren't hard-wrapped)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we open a draft RFC (in both - yarn and npm - possibly other managers?) so that we can link to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable to me, although I don't think we need to block this PR on that. We can add the links once we open the issues.