Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OOM abort error while injecting data #45

Merged
merged 4 commits into from
Sep 30, 2022
Merged

fix: OOM abort error while injecting data #45

merged 4 commits into from
Sep 30, 2022

Commits on Sep 29, 2022

  1. fix: OOM abort error while injecting data 

    After building Postject with -sASSERTIONS enabled, the error looked like
this:
```
Aborted(Cannot enlarge memory arrays to size 82239488 bytes (OOM). Either (1) compile with -sINITIAL_MEMORY=X with X higher than the current value 16777216, (2) compile with -sALLOW_MEMORY_GROWTH which allows increasing the size at runtime, or (3) if you want malloc to return NULL (0) instead of this abort, compile with -sABORTING_MALLOC=0)
```
so I followed option 2 in this change.

Fixes: #42
Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1199d24 View commit details
    Browse the repository at this point in the history

  2. fixup! test: bump test timeout 

    40000ms is still too for macOS.

Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/139/workflows/aee3c215-ddc7-4451-aad5-70bfc58dd8c3/jobs/1051/tests
Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a6f3fcd View commit details
    Browse the repository at this point in the history

  3. fixup! test: bump test timeout 

    50000ms is still too low for macOS.

Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/140/workflows/d653f352-5415-4a83-95b8-c3a52393dc76/jobs/1062/tests
Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    60688d8 View commit details
    Browse the repository at this point in the history

  4. fixup! set INITIAL_MEMORY and MAXIMUM_MEMORY 

    Resolves a code review comment.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    285825d View commit details
    Browse the repository at this point in the history