Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate npm releaser(s) for readable-stream #134

Closed
rvagg opened this issue May 23, 2015 · 11 comments
Closed

Nominate npm releaser(s) for readable-stream #134

rvagg opened this issue May 23, 2015 · 11 comments

Comments

@rvagg
Copy link
Member

rvagg commented May 23, 2015

As much as I'd like to be involved I have to be honest about my time availability and I just don't have the bandwidth to grok where this project even is at right now.

So, I'd like @nodejs/streams to nominate an individual (or >1 indiviuals if you have a plan for how that'll work) that should have npm publish rights for this package.

For background purposes, the current situation is like this:

@latest tag sticks to the 1.0.x releases where the x matches the Node.js v0.10.x version, with the code extracted out of Node.js, passed through the build/ scripts in the v0.10 branch to make it stand-alone and browserifiable. When you npm install readable-stream you get this, which is streams2.

@1.1 tag (which I don't think it's even possible to publish under with npm now because it doesn't like version-like tags) sticks to the 1.1.x releases where the x matches the Node.js v0.11.x version, with the code extracted out of Node.js, passed through the build/scripts on the master branch. You have to npm install readable-stream@1.1 (or a specific version) to get this branch, which is streams3.

We currently have nothing for 0.12 but it may make sense to continue on the 1.1.x series with those for continuity.

My hope was that we would jump a semver-major (or two) and start tracking io.js because it represents the best state of streams and it should go in @latest. How that works exactly is up to you guys.

Have a meeting, get a consensus or something and let me know who should be doing the releases.

@calvinmetcalf
Copy link
Contributor

If we were to jump to 2.0.2 that would match current node (i could merge
io-stream back in and publish it as is)

On Sat, May 23, 2015, 6:05 PM Rod Vagg notifications@github.com wrote:

As much as I'd like to be involved I have to be honest about my time
availability and I just don't have the bandwidth to grok where this project
even is at right now.

So, I'd like @nodejs/streams
https://github.com/orgs/nodejs/teams/streams to nominate an individual
(or >1 indiviuals if you have a plan for how that'll work) that should have
npm publish rights for this package.

For background purposes, the current situation is like this:

@latest tag sticks to the 1.0.x releases where the x matches the Node.js
v0.10.x version, with the code extracted out of Node.js, passed through
the build/ scripts in the v0.10 branch to make it stand-alone and
browserifiable. When you npm install readable-stream you get this, which
is streams2.

@1.1 tag (which I don't think it's even possible to publish under with
npm now because it doesn't like version-like tags) sticks to the 1.1.x
releases where the x matches the Node.js v0.11.x version, with the code
extracted out of Node.js, passed through the build/scripts on the master
branch. You have to npm install readable-stream@1.1 (or a specific
version) to get this branch, which is streams3.

We currently have nothing for 0.12 but it may make sense to continue on
the 1.1.x series with those for continuity.

My hope was that we would jump a semver-major (or two) and start tracking
io.js because it represents the best state of streams and it should go in
@latest. How that works exactly is up to you guys.

Have a meeting, get a consensus or something and let me know who should be
doing the releases.


Reply to this email directly or view it on GitHub
#134.

@mafintosh
Copy link
Member

@calvinmetcalf sounds like a good idea. @chrisdickinson thoughts?

@dcousens
Copy link

dcousens commented Jun 6, 2015

@calvinmetcalf up to the task? Need any help?

@calvinmetcalf
Copy link
Contributor

I'd be honored, I'll open a pull to get io-stream merged back in

@calvinmetcalf
Copy link
Contributor

see #135

@rvagg
Copy link
Member Author

rvagg commented Jun 9, 2015

going ahead and giving @calvinmetcalf publish rights

@calvinmetcalf: in case you're not doing this as part of your normal workflow already, please make sure you use npm version <whatever> to increment versions with npm config set sign-git-tag=true with your GPG key available and set up with git. Then we'll continue get signed git tags for each release for readable-stream.

Let us know what happens with versions, I'm still not clear on what the plan is but we'll want to update through2 to match.

@mafintosh
Copy link
Member

@rvagg @calvinmetcalf 🎉

@calvinmetcalf
Copy link
Contributor

excellent, will set up gpg now

@calvinmetcalf
Copy link
Contributor

should I publish my key somewhere ?

@rvagg
Copy link
Member Author

rvagg commented Jun 10, 2015

you can push it to the git repo itself, I can't remember the details but I'm sure google will enlighten

@calvinmetcalf
Copy link
Contributor

published, put the key in the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants